In aspnet-webpack, replace ExternalsPlugin with webpack-node-externals because of aspnet#132

Author: SteveSandersonMS

src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack/package.json

@@ -1,6 +1,6 @@
 {
 "name": "aspnet-webpack",
-"version": "1.0.11",
+"version": "1.0.12",
 "description": "Helpers for using Webpack in ASP.NET Core projects. Works in conjunction with the Microsoft.AspNetCore.SpaServices NuGet package.",
 "main": "index.js",
 "scripts":{
@@ -10,12 +10,12 @@
 "author": "Microsoft",
 "license": "Apache-2.0",
 "dependencies":{
-"es6-promise": "^3.1.2",
 "connect": "^3.4.1",
+"es6-promise": "^3.1.2",
 "memory-fs": "^0.3.0",
 "require-from-string": "^1.1.0",
 "webpack-dev-middleware": "^1.6.1",
-"webpack-externals-plugin": "^1.0.0"
+"webpack-node-externals": "^1.4.3"
  },
 "devDependencies":{
 "tsd": "0.6.5",

src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack/src/LoadViaWebpack.ts

@@ -9,10 +9,9 @@ import * as webpack from 'webpack'
 import{requireNewCopy}from'./RequireNewCopy';
 
 // Strange import syntax to work around https://github.com/Microsoft/TypeScript/issues/2719
-import{webpackexternals}from'./typings/webpack-externals-plugin';
 import{requirefromstring}from'./typings/require-from-string';
 import{memoryfs}from'./typings/memory-fs';
-constExternalsPlugin=require('webpack-externals-plugin')astypeofwebpackexternals.ExternalsPlugin;
+constnodeExternals=require('webpack-node-externals');
 constrequireFromString=require('require-from-string')astypeofrequirefromstring.requireFromString;
 constMemoryFS=require('memory-fs')astypeofmemoryfs.MemoryFS;
 
@@ -59,9 +58,19 @@ function loadViaWebpackNoCache<T>(webpackConfigPath: string, modulePath: string)
 
 // In Node, we want anything under /node_modules/ to be loaded natively and not bundled into the output
 // (partly because it's faster, but also because otherwise there'd be different instances of modules
-// depending on how they were loaded, which could lead to errors)
-webpackConfig.plugins=webpackConfig.plugins||[];
-webpackConfig.plugins.push(newExternalsPlugin({type: 'commonjs',include: /node_modules/}));
+// depending on how they were loaded, which could lead to errors).
+// ---
+// NOTE: We have to use webpack-node-externals rather than webpack-externals-plugin because
+// webpack-externals-plugin doesn't correctly resolve relative paths, which means you can't
+// use css-loader, since tries to require('./../../node_modules/css-loader/lib/css-base.js') (see #132)
+// ---
+// So, ensure that webpackConfig.externals is an array, and push WebpackNodeExternals into it:
+letexternalsArray: any[]=(webpackConfig.externalsasany[])||[];
+if(!(externalsArrayinstanceofArray)){
+externalsArray=[externalsArray];
+}
+webpackConfig.externals=externalsArray;
+externalsArray.push(nodeExternals());
 
 // The CommonsChunkPlugin is not compatible with a CommonJS environment like Node, nor is it needed in that case
 webpackConfig.plugins=webpackConfig.plugins.filter(plugin=>{

src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack/src/typings/webpack-externals-plugin.d.ts

@@ -0,0 +1,2 @@
+declare module 'webpack-node-externals'{
+}