Making the request timeout configurable.

Author: jkeyes

intercom/request.py

@@ -7,21 +7,31 @@
 importcertifi
 importjson
 importlogging
+importos
 importrequests
 
 logger=logging.getLogger('intercom.request')
 
 
+defconfigure_timeout():
+"""Configure the request timeout."""
+timeout=os.getenv('INTERCOM_REQUEST_TIMEOUT', '90')
+try:
+returnint(timeout)
+exceptValueError:
+logger.warning('%s is not a valid timeout value.', timeout)
+return90
+
+
 classRequest(object):
 
-timeout=10
+timeout=configure_timeout()
 
 def__init__(self, http_method, path, http_session=None):
 self.http_method=http_method
 self.path=path
 self.http_session=http_session
 
-
 defexecute(self, base_url, auth, params):
 returnself.send_request_to_path(base_url, auth, params)
 

tests/unit/test_request.py

@@ -332,6 +332,25 @@ def it_needs_encoding_or_apparent_encoding(self):
 @istest
 defit_allows_the_timeout_to_be_changed(self):
 fromintercom.requestimportRequest
-eq_(10, Request.timeout)
-Request.timeout=3
-eq_(3, Request.timeout)
+try:
+eq_(90, Request.timeout)
+Request.timeout=3
+eq_(3, Request.timeout)
+finally:
+Request.timeout=90
+
+@istest
+defit_allows_the_timeout_to_be_configured(self):
+importos
+fromintercom.requestimportconfigure_timeout
+
+# check the default
+eq_(90, configure_timeout())
+
+# override the default
+os.environ['INTERCOM_REQUEST_TIMEOUT'] ='20'
+eq_(20, configure_timeout())
+
+# ignore bad timeouts, reset to default 90
+os.environ['INTERCOM_REQUEST_TIMEOUT'] ='abc'
+eq_(90, configure_timeout())