Skip to content

Conversation

@edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

#1221 (comment)

What is the new behavior?

ListView now runs CD inside the ngzone, so no more conflicts with NS events occur.

Additional information

This is a workaround over a possibly more complicated issue:
#1221 (comment)

Fixes#1221 .

@edusperoniedusperoni changed the title Zone fixesfix(list-view): fix crash when used with ngForFeb 12, 2020
@cla-bot
Copy link

cla-botbot commented Sep 3, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @edusperoni.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-botcla-botbot removed the cla: yes label Sep 3, 2020
@cla-bot
Copy link

cla-botbot commented Sep 3, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @edusperoni.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@edusperoni
Copy link
CollaboratorAuthor

@cla-bot check

@cla-botcla-botbot added the cla: yes label Sep 3, 2020
@cla-bot
Copy link

cla-botbot commented Sep 3, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalkerNathanWalker merged commit 302afb3 into NativeScript:masterSep 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'destroyed' of null

2 participants

@edusperoni@NathanWalker