Skip to content

Commit bbc3661

Browse files
committed
updated norman - pep8, request.post, project __init_.py file
1 parent 0bdb6a0 commit bbc3661

File tree

6 files changed

+34
-29
lines changed

6 files changed

+34
-29
lines changed

‎part2/README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
## Links
22

3-
| Github | Heroku |
4-
|-------------------|-------------------|
5-
|[Michael Norman](https://github.com/mlnorman/python-devtest)|[reverse-flask](http://reverse-flask.herokuapp.com/)|
3+
| Github | Heroku|
4+
|--------------------------------------------------------------|-------------------------------------------------------|
5+
|[Michael Norman](https://github.com/mlnorman/python-devtest)|[reverse-flask](http://reverse-flask.herokuapp.com/)|
66
| Add link here | Add link here |
77
| Add link here | Add link here |
88
| Add link here | Add link here |

part2/reverse_flask_norman/project/app.py renamed to part2/reverse_flask_norman/project/__init__.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
fromflaskimportFlask, render_template, request, redirect, url_for
1+
fromflaskimportFlask, render_template, request, redirect, url_for
22
fromformsimportReverseForm
33

44
app=Flask(__name__)
@@ -8,22 +8,26 @@
88
defreverse(string):
99
reverse_string=""
1010
foriinxrange(len(string)):
11-
reverse_string=reverse_string+string[(len(string)-1)-i]
11+
reverse_string=reverse_string+string[(len(string)-1)-i]
1212
returnreverse_string
1313

14-
@app.route('/', methods=['GET','POST'])
14+
15+
@app.route('/', methods=['GET', 'POST'])
1516
defindex():
1617
form=ReverseForm(request.form)
17-
ifrequest.method=="POST":
18-
ifform.validate_on_submit():
19-
returnredirect(url_for('rev_string', user_input=form.reverse.data))
18+
ifform.validate_on_submit():
19+
returnredirect(url_for('rev_string', user_input=form.reverse.data))
2020
returnrender_template('index.html', form=form)
2121

2222

2323
@app.route('/reversed_input/<user_input>')
2424
defrev_string(user_input):
2525
reversed_string=reverse(user_input)
26-
returnrender_template('reversed.html',user_input=user_input, rev_input=reversed_string)
26+
returnrender_template(
27+
'reversed.html',
28+
user_input=user_input,
29+
rev_input=reversed_string
30+
)
2731

2832

2933
@app.errorhandler(403)
@@ -38,4 +42,4 @@ def page_not_found(error):
3842

3943
@app.errorhandler(500)
4044
defserver_error_page(error):
41-
returnrender_template("errors/500.html"), 500
45+
returnrender_template("errors/500.html"), 500
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# config.py
22

33
WTF_CSRF_ENABLED=True
4-
5-
SECRET_KEY="secret"
4+
SECRET_KEY="secret"

‎part2/reverse_flask_norman/project/forms.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22
fromwtformsimportTextField
33
fromwtforms.validatorsimportDataRequired
44

5+
56
classReverseForm(Form):
67
reverse=TextField('Reverse', validators=[DataRequired()])

‎part2/reverse_flask_norman/run.py‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
fromproject.appimportapp
21
importos
2+
fromprojectimportapp
33

4-
#port = int(os.environ.get('PORT', 5000))
5-
#app.run(host='0.0.0.0', port=port)
64

7-
# if pushing to heroku, use the two lines above
5+
port=int(os.environ.get('PORT', 5000))
86

9-
if__name__=="__main__":
7+
if__name__=="__main__":
108
app.run(debug=True)
11-
9+
#app.run(host='0.0.0.0', port=port) # heroku

‎part2/reverse_flask_norman/test.py‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
#tests
1+
# tests
2+
23
fromproject.appimportapp
34
importunittest
45

6+
57
classReverseCase(unittest.TestCase):
68

79
defsetUp(self):
@@ -10,11 +12,9 @@ def setUp(self):
1012

1113
deftearDown(self):
1214
pass
13-
#os.close(self.db_fd)
14-
#os.unlink(flaskr.app.config['DATABASE'])
15-
15+
1616
deftest_homepage_exists(self):
17-
response=self.app.get('/')
17+
response=self.app.get('/')
1818
self.assertEqual(response.status_code, 200)
1919
self.assertIn('Reverse this text', response.data)
2020

@@ -23,14 +23,17 @@ def test_text_is_reversed(self):
2323
self.assertIn('dlroWolleH', response.data)
2424

2525
deftest_users_must_enter_string(self):
26-
response=self.app.post('/', data=dict(
27-
reverse='', follow_redirects=True))
26+
response=self.app.post(
27+
'/',
28+
data=dict(reverse='', follow_redirects=True)
29+
)
2830
self.assertIn('This field is required', response.data)
2931

3032
deftest_redirects_to_output(self):
31-
response=self.app.post('/', data=dict(
32-
reverse="Hello",), follow_redirects=True)
33+
response=self.app.post(
34+
'/',
35+
data=dict(reverse="Hello",), follow_redirects=True)
3336
self.assertIn('olleH', response.data)
3437

3538
if__name__=='__main__':
36-
unittest.main()
39+
unittest.main()

0 commit comments

Comments
(0)