Merge pull request TooTallNate#850 from Andreas-Bur/bug-834

Fix issue TooTallNate#834 by starting WebSocketWorker of the WebSocketServer in the start function

Author: marci4

src/main/java/org/java_websocket/server/WebSocketServer.java

@@ -211,7 +211,6 @@ public WebSocketServer( InetSocketAddress address , int decodercount , List<Draf
 for( inti = 0 ; i < decodercount ; i++ ){
 WebSocketWorkerex = newWebSocketWorker();
 decoders.add( ex );
-ex.start();
  }
  }
 
@@ -229,6 +228,10 @@ public void start(){
 if( selectorthread != null )
 thrownewIllegalStateException( getClass().getName() + " can only be started once." );
 newThread( this ).start();
+
+for( WebSocketWorkerex : decoders ){
+ex.start();
+ }
  }
 
 /**

src/test/java/org/java_websocket/issues/AllIssueTests.java

@@ -41,7 +41,8 @@
 org.java_websocket.issues.Issue732Test.class,
 org.java_websocket.issues.Issue764Test.class,
 org.java_websocket.issues.Issue765Test.class,
-org.java_websocket.issues.Issue825Test.class
+org.java_websocket.issues.Issue825Test.class,
+org.java_websocket.issues.Issue834Test.class
 })
 /**
  * Start all tests for issues

src/test/java/org/java_websocket/issues/Issue834Test.java

@@ -0,0 +1,50 @@
+packageorg.java_websocket.issues;
+
+importorg.java_websocket.WebSocket;
+importorg.java_websocket.handshake.ClientHandshake;
+importorg.java_websocket.server.WebSocketServer;
+importorg.java_websocket.util.SocketUtil;
+importorg.junit.Assert;
+importorg.junit.Test;
+
+importjava.io.IOException;
+importjava.net.InetSocketAddress;
+importjava.util.Set;
+
+publicclassIssue834Test{
+
+@Test(timeout = 1000)
+publicvoidtestNoNewThreads() throwsIOException{
+
+Set<Thread> threadSet1 = Thread.getAllStackTraces().keySet();
+
+newWebSocketServer(newInetSocketAddress(SocketUtil.getAvailablePort())){
+@Override
+publicvoidonOpen(WebSocketconn, ClientHandshakehandshake){
+ }
+
+@Override
+publicvoidonClose(WebSocketconn, intcode, Stringreason, booleanremote){
+ }
+
+@Override
+publicvoidonMessage(WebSocketconn, Stringmessage){
+ }
+
+@Override
+publicvoidonError(WebSocketconn, Exceptionex){
+ }
+
+@Override
+publicvoidonStart(){
+ }
+ };
+
+Set<Thread> threadSet2 = Thread.getAllStackTraces().keySet();
+
+//checks that no threads are started in the constructor
+Assert.assertEquals(threadSet1, threadSet2);
+
+ }
+
+}