Merge branch 'master' of https://github.com/trekhleb/javascript-algorithms

Author: trekhleb

src/data-structures/heap/MinHeap.js

@@ -141,8 +141,8 @@ export default class MinHeap{
  */
 remove(item,customFindingComparator){
 // Find number of items to remove.
-constnumberOfItemsToRemove=this.find(item).length;
 constcustomComparator=customFindingComparator||this.compare;
+constnumberOfItemsToRemove=this.find(item,customComparator).length;
 
 for(letiteration=0;iteration<numberOfItemsToRemove;iteration+=1){
 // We need to find item index to remove each time after removal since

src/data-structures/heap/__test__/MinHeap.test.js

@@ -1,4 +1,5 @@
 importMinHeapfrom'../MinHeap';
+importComparatorfrom'../../../utils/comparator/Comparator';
 
 describe('MinHeap',()=>{
 it('should create an empty min heap',()=>{
@@ -147,4 +148,25 @@ describe('MinHeap', () =>{
 expect(minHeap.remove(3).toString()).toEqual('4');
 expect(minHeap.remove(4).toString()).toEqual('');
 });
+
+it('should be possible to remove items from heap with custom finding comparator',()=>{
+constminHeap=newMinHeap();
+minHeap.add('dddd');
+minHeap.add('ccc');
+minHeap.add('bb');
+minHeap.add('a');
+
+expect(minHeap.toString()).toBe('a,bb,ccc,dddd');
+
+constcomparator=newComparator((a,b)=>{
+if(a.length===b.length){
+return0;
+}
+
+returna.length<b.length ? -1 : 1;
+});
+
+minHeap.remove('hey',comparator);
+expect(minHeap.toString()).toBe('a,bb,dddd');
+});
 });