test: check against run-time OpenSSL version

Update `common.hasOpenSSL3*` to check against the run-time version of OpenSSL instead of the version of OpenSSL that Node.js was compiled against. Add a generalized `common.hasOpenSSL()` so we do not need to keep adding new checks for each new major/minor of OpenSSL. PR-URL: nodejs#53456 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>

Author: richardlau

test/common/index.js

@@ -57,14 +57,24 @@ const noop = () =>{};
 consthasCrypto=Boolean(process.versions.openssl)&&
 !process.env.NODE_SKIP_CRYPTO;
 
-consthasOpenSSL3=hasCrypto&&
-require('crypto').constants.OPENSSL_VERSION_NUMBER>=0x30000000;
-
-consthasOpenSSL31=hasCrypto&&
-require('crypto').constants.OPENSSL_VERSION_NUMBER>=0x30100000;
+// Synthesize OPENSSL_VERSION_NUMBER format with the layout 0xMNN00PPSL
+constopensslVersionNumber=(major=0,minor=0,patch=0)=>{
+assert(major>=0&&major<=0xf);
+assert(minor>=0&&minor<=0xff);
+assert(patch>=0&&patch<=0xff);
+return(major<<28)|(minor<<20)|(patch<<4);
+};
 
-consthasOpenSSL32=hasCrypto&&
-require('crypto').constants.OPENSSL_VERSION_NUMBER>=0x30200000;
+letOPENSSL_VERSION_NUMBER;
+consthasOpenSSL=(major=0,minor=0,patch=0)=>{
+if(!hasCrypto)returnfalse;
+if(OPENSSL_VERSION_NUMBER===undefined){
+constregexp=/(?<m>\d+)\.(?<n>\d+)\.(?<p>\d+)/;
+const{ m, n, p }=process.versions.openssl.match(regexp).groups;
+OPENSSL_VERSION_NUMBER=opensslVersionNumber(m,n,p);
+}
+returnOPENSSL_VERSION_NUMBER>=opensslVersionNumber(major,minor,patch);
+};
 
 consthasQuic=hasCrypto&&!!process.config.variables.openssl_quic;
 
@@ -977,9 +987,7 @@ const common ={
  getTTYfd,
  hasIntl,
  hasCrypto,
- hasOpenSSL3,
- hasOpenSSL31,
- hasOpenSSL32,
+ hasOpenSSL,
  hasQuic,
  hasMultiLocalhost,
  invalidArgTypeHelper,
@@ -1040,6 +1048,18 @@ const common ={
 });
 },
 
+gethasOpenSSL3(){
+returnhasOpenSSL(3);
+},
+
+gethasOpenSSL31(){
+returnhasOpenSSL(3,1);
+},
+
+gethasOpenSSL32(){
+returnhasOpenSSL(3,2);
+},
+
 getinFreeBSDJail(){
 if(inFreeBSDJail!==null)returninFreeBSDJail;
 

test/parallel/test-crypto-dh.js

@@ -86,8 +86,8 @@ const crypto = require('crypto');
 }
 
 {
-constv=crypto.constants.OPENSSL_VERSION_NUMBER;
-consthasOpenSSL3WithNewErrorMessage=(v>=0x300000c0&&v<=0x30100000)||(v>=0x30100040&&v<=0x30200000);
+consthasOpenSSL3WithNewErrorMessage=(common.hasOpenSSL(3,0,12)&&!common.hasOpenSSL(3,1,1))||
+(common.hasOpenSSL(3,1,4)&&!common.hasOpenSSL(3,2,1));
 assert.throws(()=>{
 dh3.computeSecret('');
 },{message: common.hasOpenSSL3&&!hasOpenSSL3WithNewErrorMessage ?