Skip to content

Commit fa77543

Browse files
committed
rn-106: add URL update article
1 parent cf3c651 commit fa77543

File tree

1 file changed

+66
-2
lines changed

1 file changed

+66
-2
lines changed

‎rev_news/drafts/edition-106.md‎

Lines changed: 66 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,73 @@ This edition covers what happened during the months of November 2023 and Decembe
2121
### General
2222
-->
2323

24-
<!---
2524
### Reviews
26-
-->
25+
26+
+[[PATCH 0/4] Switch links to https](https://lore.kernel.org/git/[email protected]/)
27+
28+
Last September Josh Soref posted a 4 patch long series on the
29+
mailing list to improve the URLs used throughout the documentation
30+
and the code base of the project.
31+
32+
The main goal was to use HTTPS instead of HTTP in the URLs to
33+
improve user security, but along the way some patches replaced URLs
34+
that didn't work anymore with some new ones pointing to the same
35+
content.
36+
37+
Eric Sunshine replied to Josh's patches asking why one ULR was
38+
changed from `http://json.org/` to `https://www.json.org/` instead
39+
of just replacing `http` with `https`. Josh replied that it was
40+
because that website was self-identifying with the later URL using a
41+
[meta refresh](https://en.wikipedia.org/wiki/Meta_refresh).
42+
43+
In the meantime, Junio Hamano, the Git maintainer, replied to some
44+
patches saying that it might not be worth updating some URLs, either
45+
because it was clear from the context that they were old, or because
46+
they were part of some code we borrowed from other projects. In some
47+
cases, they were an argument of a Git command and still just worked,
48+
while the meaning of the command changed a bit when `http` was
49+
replaced with `https`. Junio liked the fact that some broken links
50+
were fixed by the series though.
51+
52+
Josh then sent a
53+
[version 2 of his patch series](https://lore.kernel.org/git/[email protected]/).
54+
This took into account Eric's comments as a commit message was
55+
improved to say that some changes were made to respect a site's
56+
self-identification. Junio's comments were also taken into account
57+
as a number of URLs that were previously changed were now left
58+
as-is.
59+
60+
Elijah Newren and Junio commented on this new version. They both
61+
suggested improving commit messages or the cover letter of the
62+
series to better explain the reasons for the changes that were made.
63+
In one case, Elijah and Josh discussed replacing the URL of a
64+
website that seemed to be often down with a link to its content on
65+
the [Internet Archive](https://archive.org/).
66+
67+
Last November, Josh then sent a
68+
[version 3 of his patch series](https://lore.kernel.org/git/[email protected]/)
69+
where the first and second patches had been swapped to avoid some
70+
confusion for reviewers who would ask why some URLs weren't changed
71+
in the first patch overlooking that the second one would change them.
72+
73+
The other significant change compared to version 2 was that Josh
74+
decided not to replace the URL of the website that was often down
75+
saying "we'll risk users getting hacked content from an arbitrary
76+
[MITM](https://en.wikipedia.org/wiki/Man-in-the-middle_attack)
77+
instead of taking archived authenticated content based on the last
78+
time their web site was properly maintained".
79+
80+
Elijah replied that he would be fine with using the archived link if
81+
it was better justified in the commit message. But said that he also
82+
agreed with merging the whole series as-is, as he had checked all
83+
the links and they all looked good to him.
84+
85+
Josh replied he could come back later to change the URL and prefered
86+
the series to be merged as-is. He thanked Elijah for taking the time
87+
to re-check every link, saying he knew exactly how tedious that is.
88+
89+
Junio agreed with merging the series, which is now part of the
90+
'master' branch.
2791

2892
<!---
2993
### Support

0 commit comments

Comments
(0)