Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository:RcppCore/RcppParallel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:master
Choose a base ref
...
head repository:clhunsen/RcppParallel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 28, 2018

  1. Fix finding of CXX prefix

    When configuring the package, the finding of the correct CXX prefix is crucial (see the file 'tools/config/configure.R'). As the function call 'read_r_config' (and, thus, 'R CMD config') does not return 'NULL' (but an error message) if a constant is not configured, the wrong prefix is chosen. This results in compilation errors. To fix this problem, it needs to be checked whether the call to 'read_r_config' returns an error messsage or not. Additionally, remove trailing whitespace in 'tools/config/configure.R'. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
    @clhunsen
    clhunsen committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    8bbf1d9View commit details
    Browse the repository at this point in the history
Loading