Revert IsWarning code path to avoid breaking change (e.g., if someone overrode OnErrorDataReceived to receive such lines)

SteveSandersonMS · SteveSandersonMS · commit 8544714cbb4d · 2017-03-29T12:02:02.000+01:00
diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs
@@ -383,10 +383,6 @@ private void ConnectToInputOutputStreams()
{
 OutputLogger.LogWarning(evt.Data);
 }
- else if (IsWarning(evt.Data))
-{
- OutputLogger.LogWarning(evt.Data);
- }
 else if (!initializationIsCompleted)
{
 _connectionIsReadySource.SetException(
@@ -412,11 +408,6 @@ private static bool IsDebuggerMessage(string message)
 message.Contains("chrome-devtools:");
 }
 
- private static bool IsWarning(string message)
-{
- return message.StartsWith("Warning:", StringComparison.OrdinalIgnoreCase);
- }
-
 private FileSystemWatcher BeginFileWatcher(string rootDir)
{
 if (_watchFileExtensions == null || _watchFileExtensions.Length == 0)

Original file line number	Diff line number	Diff line change
`@@ -383,10 +383,6 @@ private void ConnectToInputOutputStreams()`
`383`	`383`	`{`
`384`	`384`	`OutputLogger.LogWarning(evt.Data);`
`385`	`385`	`}`
`386`		`-elseif(IsWarning(evt.Data))`
`387`		`-{`
`388`		`-OutputLogger.LogWarning(evt.Data);`
`389`		`-}`
`390`	`386`	`elseif(!initializationIsCompleted)`
`391`	`387`	`{`
`392`	`388`	`_connectionIsReadySource.SetException(`
`@@ -412,11 +408,6 @@ private static bool IsDebuggerMessage(string message)`
`412`	`408`	`message.Contains("chrome-devtools:");`
`413`	`409`	`}`
`414`	`410`
`415`		`-privatestaticboolIsWarning(stringmessage)`
`416`		`-{`
`417`		`-returnmessage.StartsWith("Warning:",StringComparison.OrdinalIgnoreCase);`
`418`		`-}`
`419`		`-`
`420`	`411`	`privateFileSystemWatcherBeginFileWatcher(stringrootDir)`
`421`	`412`	`{`
`422`	`413`	`if(_watchFileExtensions==null\|\|_watchFileExtensions.Length==0)`