feat: support disabling the built-in updater

Author: ethanndickson

Coder-Desktop/Coder-Desktop/UpdaterService.swift

@@ -2,42 +2,64 @@ import Sparkle
 import SwiftUI
 
 finalclassUpdaterService:NSObject,ObservableObject{
-private lazy varinner:SPUStandardUpdaterController=.init(
- startingUpdater:true,
- updaterDelegate:self,
- userDriverDelegate:self
-)
-privatevarupdater:SPUUpdater!
+
+ // The auto-updater can be entirely disabled by setting the
+ // `disableUpdater` UserDefaults key to `true`. This is designed for use in
+ // MDM configurations, where the value can be set to `true` permanently.
+@Publishedvardisabled:Bool=UserDefaults.standard.bool(forKey:Keys.disableUpdater){
+ didSet {
+UserDefaults.standard.set(disabled, forKey:Keys.disableUpdater)
+}
+}
+
 @PublishedvarcanCheckForUpdates=true
 
 @PublishedvarautoCheckForUpdates:Bool!{
  didSet {
 iflet autoCheckForUpdates, autoCheckForUpdates != oldValue {
- updater.automaticallyChecksForUpdates = autoCheckForUpdates
+inner?.updater.automaticallyChecksForUpdates = autoCheckForUpdates
 }
 }
 }
 
 @PublishedvarupdateChannel:UpdateChannel{
  didSet {
-UserDefaults.standard.set(updateChannel.rawValue, forKey:Self.updateChannelKey)
+UserDefaults.standard.set(updateChannel.rawValue, forKey:Keys.updateChannel)
 }
 }
+privatevarinner:(controller:SPUStandardUpdaterController, updater:SPUUpdater)?
 
-staticletupdateChannelKey="updateChannel"
 
 overrideinit(){
- updateChannel =UserDefaults.standard.string(forKey:Self.updateChannelKey)
+ updateChannel =UserDefaults.standard.string(forKey:Keys.updateChannel)
 .flatMap{UpdateChannel(rawValue: $0)}??.stable
  super.init()
- updater = inner.updater
+
+guard !disabled else{
+return
+}
+
+letinner=SPUStandardUpdaterController(
+ startingUpdater:true,
+ updaterDelegate:self,
+ userDriverDelegate:self
+)
+
+letupdater= inner.updater
+self.inner =(inner, updater)
+
  autoCheckForUpdates = updater.automaticallyChecksForUpdates
  updater.publisher(for: \.canCheckForUpdates).assign(to:&$canCheckForUpdates)
 }
 
 func checkForUpdates(){
-guard canCheckForUpdates else{return}
- updater.checkForUpdates()
+guardlet inner, canCheckForUpdates else{return}
+ inner.updater.checkForUpdates()
+}
+
+enumKeys{
+staticletdisableUpdater="disableUpdater"
+staticletupdateChannel="updateChannel"
 }
 }
 

Coder-Desktop/Coder-Desktop/Views/Settings/GeneralTab.swift

@@ -19,18 +19,20 @@ struct GeneralTab: View{
 Text("Start Coder Connect on launch")
 }
 }
-Section{
-Toggle(isOn: $updater.autoCheckForUpdates){
-Text("Automatically check for updates")
-}
-Picker("Update channel", selection: $updater.updateChannel){
-ForEach(UpdateChannel.allCases){ channel in
-Text(channel.name).tag(channel)
+if !updater.disabled {
+Section{
+Toggle(isOn: $updater.autoCheckForUpdates){
+Text("Automatically check for updates")
+}
+Picker("Update channel", selection: $updater.updateChannel){
+ForEach(UpdateChannel.allCases){ channel in
+Text(channel.name).tag(channel)
+}
+}
+HStack{
+Spacer()
+Button("Check for updates"){ updater.checkForUpdates()}.disabled(!updater.canCheckForUpdates)
 }
-}
-HStack{
-Spacer()
-Button("Check for updates"){ updater.checkForUpdates()}.disabled(!updater.canCheckForUpdates)
 }
 }
 }.formStyle(.grouped)