impl: store last used URL in Toolbox Settings Store (#200)

Context: Toolbox can store key/value pairs in two places: - a settings store which is backed by a clear text json file per each plugin - native keystore for sensitive data At the same time some of Coder's clients (ex: Netflix) would like to deploy at scale preconfigured settings for Toolbox. Most of the needed settings are part of json backed store except the last used URL. This PR reworks the code around the last used URL/token and moves the URL in the json backed store, making it easy to configure. At the same time we still support the pair stored in the native keystore for backward compatibility reasons.

Author: fioan89

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Changed
+
+- simplified storage for last used url and token
+
 ## 0.6.6 - 2025-09-24
 
 ### Changed

gradle.properties

@@ -1,3 +1,3 @@
-version=0.6.6
+version=0.7.0
 group=com.coder.toolbox
 name=coder-toolbox

src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt

@@ -7,7 +7,6 @@ import com.coder.toolbox.sdk.ex.APIResponseException
 importcom.coder.toolbox.sdk.v2.models.WorkspaceStatus
 importcom.coder.toolbox.util.CoderProtocolHandler
 importcom.coder.toolbox.util.DialogUi
-importcom.coder.toolbox.util.toURL
 importcom.coder.toolbox.util.waitForTrue
 importcom.coder.toolbox.util.withPath
 importcom.coder.toolbox.views.Action
@@ -364,8 +363,8 @@ class CoderRemoteProvider(
 if (shouldDoAutoSetup()){
 try{
 CoderCliSetupContext.apply{
- url = context.secrets.lastDeploymentURL.toURL()
- token = context.secrets.lastToken
+ url = context.deploymentUrl
+ token = context.secrets.tokenFor(context.deploymentUrl)
  }
 CoderCliSetupWizardState.goToStep(WizardStep.CONNECT)
 returnCoderCliSetupWizardPage(
@@ -399,14 +398,15 @@ class CoderRemoteProvider(
  * Auto-login only on first the firs run if there is a url & token configured or the auth
  * should be done via certificates.
 */
-privatefunshouldDoAutoSetup(): Boolean= firstRun && (context.secrets.canAutoLogin ||!settings.requireTokenAuth)
+privatefunshouldDoAutoSetup(): Boolean= firstRun && (canAutoLogin() ||!settings.requireTokenAuth)
+
+funcanAutoLogin(): Boolean=!context.secrets.tokenFor(context.deploymentUrl).isNullOrBlank()
 
 privatefunonConnect(client:CoderRestClient, cli:CoderCLIManager){
 // Store the URL and token for use next time.
- context.secrets.lastDeploymentURL =client.url.toString()
+ context.settingsStore.updateLastUsedUrl(client.url)
 if (context.settingsStore.requireTokenAuth){
- context.secrets.lastToken = client.token ?:""
- context.secrets.storeTokenFor(client.url, context.secrets.lastToken)
+ context.secrets.storeTokenFor(client.url, client.token ?:"")
  context.logger.info("Deployment URL and token were stored and will be available for automatic connection")
  } else{
  context.logger.info("Deployment URL was stored and will be available for automatic connection")

src/main/kotlin/com/coder/toolbox/CoderToolboxContext.kt

@@ -36,17 +36,15 @@ data class CoderToolboxContext(
  *
  * In order of preference:
  *
- * 1. Last used URL.
- * 2. URL in settings.
- * 3. CODER_URL.
- * 4. URL in global cli config.
+ * 1. Last used URL from the settings.
+ * 2. Last used URL from the secrets store.
+ * 3. Default URL
 */
 val deploymentUrl:URL
  get(){
-if (this.secrets.lastDeploymentURL.isNotBlank()){
-returnthis.secrets.lastDeploymentURL.toURL()
- }
-returnthis.settingsStore.defaultURL.toURL()
+return settingsStore.lastDeploymentURL?.takeIf{it.isNotBlank() }?.toURL()
+?: secrets.lastDeploymentURL.takeIf{it.isNotBlank() }?.toURL()
+?: settingsStore.defaultURL.toURL()
  }
 
 suspendfunlogAndShowError(title:String, error:String){

src/main/kotlin/com/coder/toolbox/settings/ReadOnlyCoderSettings.kt

@@ -8,6 +8,12 @@ import java.util.Locale.getDefault
  * Read-only interface for accessing Coder settings
 */
 interfaceReadOnlyCoderSettings{
+
+/**
+ * The last used deployment URL.
+*/
+val lastDeploymentURL:String?
+
 /**
  * The default URL to show in the connection window.
 */

src/main/kotlin/com/coder/toolbox/store/CoderSecretsStore.kt

@@ -8,24 +8,11 @@ import java.net.URL
  * Provides Coder secrets backed by the secrets store service.
 */
 classCoderSecretsStore(privatevalstore:PluginSecretStore){
-privatefunget(key:String): String= store[key] ?:""
-
-privatefunset(key:String, value:String){
-if (value.isBlank()){
- store.clear(key)
- } else{
- store[key] = value
- }
- }
-
-var lastDeploymentURL:String
- get() = get("last-deployment-url")
- set(value) = set("last-deployment-url", value)
-var lastToken:String
- get() = get("last-token")
- set(value) = set("last-token", value)
-val canAutoLogin:Boolean
- get() = lastDeploymentURL.isNotBlank() && lastToken.isNotBlank()
+ @Deprecated(
+ message ="The URL is now stored the JSON backed settings store. Use CoderSettingsStore#lastDeploymentURL",
+ replaceWith =ReplaceWith("context.settingsStore.lastDeploymentURL")
+ )
+val lastDeploymentURL:String= store["last-deployment-url"] ?:""
 
 funtokenFor(url:URL): String?= store[url.host]
 

src/main/kotlin/com/coder/toolbox/store/CoderSettingsStore.kt

@@ -36,6 +36,7 @@ class CoderSettingsStore(
  ) : ReadOnlyTLSSettings
 
 // Properties implementation
+overrideval lastDeploymentURL:String? get() = store[LAST_USED_URL]
 overrideval defaultURL:String get() = store[DEFAULT_URL] ?:"https://dev.coder.com"
 overrideval binarySource:String? get() = store[BINARY_SOURCE]
 overrideval binaryDirectory:String? get() = store[BINARY_DIRECTORY]
@@ -155,6 +156,10 @@ class CoderSettingsStore(
 funreadOnly(): ReadOnlyCoderSettings=this
 
 // Write operations
+funupdateLastUsedUrl(url:URL){
+ store[LAST_USED_URL] = url.toString()
+ }
+
 funupdateBinarySource(source:String){
  store[BINARY_SOURCE] = source
  }

src/main/kotlin/com/coder/toolbox/store/StoreKeys.kt

@@ -2,7 +2,7 @@ package com.coder.toolbox.store
 
 internalconstvalCODER_SSH_CONFIG_OPTIONS="CODER_SSH_CONFIG_OPTIONS"
 
-internalconstvalCODER_URL="CODER_URL"
+internalconstvalLAST_USED_URL="lastDeploymentURL"
 
 internalconstvalDEFAULT_URL="defaultURL"
 

src/main/kotlin/com/coder/toolbox/views/DeploymentUrlStep.kt

@@ -63,8 +63,8 @@ class DeploymentUrlStep(
  errorField.textState.update{
  context.i18n.pnotr("")
  }
- urlField.textState.update{
- context.secrets.lastDeploymentURL
+ urlField.contentState.update{
+ context.deploymentUrl.toString()
  }
 
  signatureFallbackStrategyField.checkedState.update{