Fix command palette visibility with proper "when" clause placement

Move "when" clauses from command definitions to menus.commandPalette section. This fixes commands like Logout and Create Workspace appearing in the palette before the user is authenticated.

Author: EhabY

package.json

@@ -192,67 +192,67 @@
 "commands": [
 {
 "command": "coder.login",
-"title": "Coder: Login"
+"title": "Login",
+"category": "Coder",
+"icon": "$(sign-in)"
  },
 {
 "command": "coder.logout",
-"title": "Coder: Logout",
-"when": "coder.authenticated",
+"title": "Logout",
+"category": "Coder",
 "icon": "$(sign-out)"
  },
 {
 "command": "coder.open",
 "title": "Open Workspace",
-"icon": "$(play)",
-"category": "Coder"
+"category": "Coder",
+"icon": "$(play)"
  },
 {
 "command": "coder.openFromSidebar",
-"title": "Coder: Open Workspace",
+"title": "Open Workspace",
+"category": "Coder",
 "icon": "$(play)"
  },
 {
 "command": "coder.createWorkspace",
 "title": "Create Workspace",
 "category": "Coder",
-"when": "coder.authenticated",
 "icon": "$(add)"
  },
 {
 "command": "coder.navigateToWorkspace",
 "title": "Navigate to Workspace Page",
-"when": "coder.authenticated",
+"category": "Coder",
 "icon": "$(link-external)"
  },
 {
 "command": "coder.navigateToWorkspaceSettings",
 "title": "Edit Workspace Settings",
-"when": "coder.authenticated",
+"category": "Coder",
 "icon": "$(settings-gear)"
  },
 {
 "command": "coder.workspace.update",
-"title": "Coder: Update Workspace",
-"when": "coder.workspace.updatable"
+"title": "Update Workspace",
+"category": "Coder"
  },
 {
 "command": "coder.refreshWorkspaces",
 "title": "Refresh Workspace",
 "category": "Coder",
-"icon": "$(refresh)",
-"when": "coder.authenticated"
+"icon": "$(refresh)"
  },
 {
 "command": "coder.viewLogs",
 "title": "Coder: View Logs",
-"icon": "$(list-unordered)",
-"when": "coder.authenticated"
+"icon": "$(list-unordered)"
  },
 {
 "command": "coder.openAppStatus",
-"title": "Coder: Open App Status",
-"icon": "$(robot)",
-"when": "coder.authenticated"
+"title": "Open App Status",
+"category": "Coder",
+"icon": "$(robot)"
  },
 {
 "command": "coder.searchMyWorkspaces",
@@ -274,6 +274,41 @@
  ],
 "menus":{
 "commandPalette": [
+{
+"command": "coder.login",
+"when": "!coder.authenticated"
+ },
+{
+"command": "coder.logout",
+"when": "coder.authenticated"
+ },
+{
+"command": "coder.createWorkspace",
+"when": "coder.authenticated"
+ },
+{
+"command": "coder.navigateToWorkspace",
+"when": "coder.authenticated"
+ },
+{
+"command": "coder.navigateToWorkspaceSettings",
+"when": "coder.authenticated"
+ },
+{
+"command": "coder.workspace.update",
+"when": "coder.workspace.updatable"
+ },
+{
+"command": "coder.refreshWorkspaces",
+"when": "coder.authenticated"
+ },
+{
+"command": "coder.viewLogs"
+ },
+{
+"command": "coder.openAppStatus",
+"when": "coder.authenticated"
+ },
 {
 "command": "coder.debug.listDeployments",
 "when": "coder.devMode"

src/api/utils.ts

@@ -1,4 +1,4 @@
-importfsfrom"fs/promises";
+importfsfrom"node:fs/promises";
 import{ProxyAgent}from"proxy-agent";
 import{typeWorkspaceConfiguration}from"vscode";
 

src/remote/sshProcess.ts

@@ -256,8 +256,9 @@ export class SshProcessMonitor implements vscode.Disposable{
 consttargetPid=this.currentPid;
 while(!this.disposed&&this.currentPid===targetPid){
 try{
-constlogFiles=awaitfs.readdir(logDir);
-logFiles.sort().reverse();
+constlogFiles=(awaitfs.readdir(logDir))
+.sort((a,b)=>a.localeCompare(b))
+.reverse();
 constlogFileName=logFiles.find(
 (file)=>
 file===`${targetPid}.log`||file.endsWith(`-${targetPid}.log`),
@@ -420,7 +421,7 @@ async function findRemoteSshLogPath(
 constdirs=awaitfs.readdir(logsParentDir);
 constoutputDirs=dirs
 .filter((d)=>d.startsWith("output_logging_"))
-.sort()
+.sort((a,b)=>a.localeCompare(b))
 .reverse();
 
 if(outputDirs.length>0){