perf(bump): avoid unnecessary list construction and rename variable to avoid confusion

bearomorphism · Lee-W · commit a9cd957819a2 · 2025-06-08T21:30:08.000+08:00
diff --git a/commitizen/bump.py b/commitizen/bump.py
@@ -3,6 +3,7 @@
 import os
 import re
 from collections import OrderedDict
+from collections.abc import Iterable
 from glob import iglob
 from logging import getLogger
 from string import Template
@@ -61,7 +62,7 @@ def find_increment(
 def update_version_in_files(
 current_version: str,
 new_version: str,
- files: list[str],
+ files: Iterable[str],
 *,
 check_consistency: bool = False,
 encoding: str = ENCODING,
@@ -99,21 +100,22 @@ def update_version_in_files(
 return updated
 
 
-def _files_and_regexes(patterns: list[str], version: str) -> list[tuple[str, str]]:
+def _files_and_regexes(patterns: Iterable[str], version: str) -> list[tuple[str, str]]:
 """
 Resolve all distinct files with their regexp from a list of glob patterns with optional regexp
 """
- out: list[tuple[str, str]] = []
+ out: set[tuple[str, str]] = set()
 for pattern in patterns:
 drive, tail = os.path.splitdrive(pattern)
 path, _, regex = tail.partition(":")
 filepath = drive + path
 if not regex:
 regex = re.escape(version)
 
- for path in iglob(filepath):
- out.append((path, regex))
- return sorted(list(set(out)))
+ for file in iglob(filepath):
+ out.add((file, regex))
+
+ return sorted(out)
 
 
 def _bump_with_regex(

-Original file line number
+Diff line change
 importos
 importre
 fromcollectionsimportOrderedDict
 +fromcollections.abcimportIterable
 fromglobimportiglob
 fromloggingimportgetLogger
 fromstringimportTemplate
 defupdate_version_in_files(
 current_version: str,
 new_version: str,
 -files: list[str],
 +files: Iterable[str],
 *,
 check_consistency: bool=False,
 encoding: str=ENCODING,
 returnupdated
 -def_files_and_regexes(patterns: list[str], version: str) ->list[tuple[str, str]]:
 +def_files_and_regexes(patterns: Iterable[str], version: str) ->list[tuple[str, str]]:
 """
  Resolve all distinct files with their regexp from a list of glob patterns with optional regexp
  """
 -out: list[tuple[str, str]] =[]
 +out: set[tuple[str, str]] =set()
 forpatterninpatterns:
 drive, tail=os.path.splitdrive(pattern)
 path, _, regex=tail.partition(":")
 filepath=drive+path
 ifnotregex:
 regex=re.escape(version)
 -forpathiniglob(filepath):
 -out.append((path, regex))
 -returnsorted(list(set(out)))
 +forfileiniglob(filepath):
 +out.add((file, regex))
++
 +returnsorted(out)
 def_bump_with_regex(