test(bump_rule): raise error

bearomorphism · bearomorphism · commit facb51c1e8ea · 2025-05-18T03:30:44.000+08:00
diff --git a/commitizen/bump_rule.py b/commitizen/bump_rule.py
@@ -96,9 +96,9 @@ def __init__(
 bump_map: dict[str, Increment],
 bump_map_major_version_zero: dict[str, Increment],
 ):
- if not bump_map or not bump_pattern:
+ if not bump_map or not bump_pattern or not bump_map_major_version_zero:
 raise NoPatternMapError(
- f"Invalid bump rule:{bump_pattern=} and{bump_map=}"
+ f"Invalid bump rule:{bump_pattern=} and{bump_map=} and{bump_map_major_version_zero=}"
 )
 
 self.bump_pattern = re.compile(bump_pattern)
diff --git a/tests/test_bump_rule.py b/tests/test_bump_rule.py
@@ -244,6 +244,26 @@ def test_invalid_bump_map(self, bump_pattern):
 with pytest.raises(NoPatternMapError):
 OldSchoolBumpRule(bump_pattern,{},{})
 
+ def test_invalid_bump_map_major_version_zero(self, bump_pattern, bump_map):
+ with pytest.raises(NoPatternMapError):
+ OldSchoolBumpRule(bump_pattern, bump_map,{})
+
+ def test_all_invalid(self):
+ with pytest.raises(NoPatternMapError):
+ OldSchoolBumpRule("",{},{})
+
+ def test_none_values(self):
+ with pytest.raises(NoPatternMapError):
+ OldSchoolBumpRule(None,{},{})
+
+ def test_empty_pattern_with_valid_maps(self, bump_map, bump_map_major_version_zero):
+ with pytest.raises(NoPatternMapError):
+ OldSchoolBumpRule("", bump_map, bump_map_major_version_zero)
+
+ def test_empty_maps_with_valid_pattern(self, bump_pattern):
+ with pytest.raises(NoPatternMapError):
+ OldSchoolBumpRule(bump_pattern,{},{})
+
 def test_complex_pattern(self):
 pattern = r"^.*?\[(.*?)\].*?\[(.*?)\].*$"
 bump_map ={

-Original file line number
+Diff line change
 bump_map: dict[str, Increment],
 bump_map_major_version_zero: dict[str, Increment],
  ):
 -ifnotbump_mapornotbump_pattern:
 +ifnotbump_mapornotbump_patternornotbump_map_major_version_zero:
 raiseNoPatternMapError(
 -f"Invalid bump rule: {bump_pattern=} and {bump_map=}"
 +f"Invalid bump rule: {bump_pattern=} and {bump_map=} and {bump_map_major_version_zero=}"
+ )
 self.bump_pattern=re.compile(bump_pattern)
-Original file line number
+Diff line change
 withpytest.raises(NoPatternMapError):
 OldSchoolBumpRule(bump_pattern,{},{})
 +deftest_invalid_bump_map_major_version_zero(self, bump_pattern, bump_map):
 +withpytest.raises(NoPatternMapError):
 +OldSchoolBumpRule(bump_pattern, bump_map,{})
++
 +deftest_all_invalid(self):
 +withpytest.raises(NoPatternMapError):
 +OldSchoolBumpRule("",{},{})
++
 +deftest_none_values(self):
 +withpytest.raises(NoPatternMapError):
 +OldSchoolBumpRule(None,{},{})
++
 +deftest_empty_pattern_with_valid_maps(self, bump_map, bump_map_major_version_zero):
 +withpytest.raises(NoPatternMapError):
 +OldSchoolBumpRule("", bump_map, bump_map_major_version_zero)
++
 +deftest_empty_maps_with_valid_pattern(self, bump_pattern):
 +withpytest.raises(NoPatternMapError):
 +OldSchoolBumpRule(bump_pattern,{},{})
++
 deftest_complex_pattern(self):
 pattern=r"^.*?\[(.*?)\].*?\[(.*?)\].*$"
 bump_map={