Skip to content

Commit 1b96fd3

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent 42b375a commit 1b96fd3

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323
This completes the view to provide all the REQUIRED and RECOMMENDED [OpenID Provider Metadata](https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata).
2424

2525
### Changed
26-
*#1129 (**Breaking**) Changed default value of PKCE_REQUIRED to True. This is a **breaking change**. Clients without
26+
*#1129 (**Breaking**) Changed default value of PKCE_REQUIRED to True. This is a **breaking change**. Clients without
2727
PKCE enabled with fail to authenticate. This breaks with [section 5 of RFC7636](https://datatracker.ietf.org/doc/html/rfc7636)
2828
in favor of the [OAuth2 Security Best Practices for Authorization Code Grants](`Authorization Code Grant <https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics#section-2.1.>`_ )
29-
To maintain the legacy behavior set [PKCE_REQUIRED](https://django-oauth-toolkit.readthedocs.io/en/latest/settings.html?highlight=PKCE_REQUIRED#pkce-required)
29+
To maintain the legacy behavior set [PKCE_REQUIRED](https://django-oauth-toolkit.readthedocs.io/en/latest/settings.html?highlight=PKCE_REQUIRED#pkce-required)
3030
to `False`.
3131
*#1093 (**Breaking**) Changed to implement [hashed](https://docs.djangoproject.com/en/stable/topics/auth/passwords/)
3232
client_secret values. This is a **breaking change** that will migrate all your existing

‎docs/settings.rst‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,10 +257,10 @@ Default: ``True``
257257

258258
Can be either a bool or a callable that takes a client id and returns a bool.
259259

260-
Whether or not `Proof Key for Code Exchange <https://oauth.net/2/pkce/>`_ is required.
260+
Whether or not `Proof Key for Code Exchange <https://oauth.net/2/pkce/>`_ is required.
261261

262-
According to `OAuth 2.0 Security Best Current Practice <https://oauth.net/2/oauth-best-practice/>`_ related to the
263-
`Authorization Code Grant <https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics#section-2.1.>`_
262+
According to `OAuth 2.0 Security Best Current Practice <https://oauth.net/2/oauth-best-practice/>`_ related to the
263+
`Authorization Code Grant <https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics#section-2.1.>`_
264264

265265
- Public clients MUST use PKCE `RFC7636 <https://datatracker.ietf.org/doc/html/rfc7636>`_
266266
- For confidential clients, the use of PKCE `RFC7636 <https://datatracker.ietf.org/doc/html/rfc7636>`_ is RECOMMENDED.

‎tests/test_hybrid.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def setUp(self):
5252
self.factory=RequestFactory()
5353
self.hy_test_user=UserModel.objects.create_user("hy_test_user", "[email protected]", "123456")
5454
self.hy_dev_user=UserModel.objects.create_user("hy_dev_user", "[email protected]", "123456")
55-
self.oauth2_settings.PKCE_REQUIRED=False
55+
self.oauth2_settings.PKCE_REQUIRED=False
5656
self.oauth2_settings.ALLOWED_REDIRECT_URI_SCHEMES= ["http", "custom-scheme"]
5757

5858
self.application=Application(

0 commit comments

Comments
(0)