Skip to content

Commit f29b4f5

Browse files
committed
rn-38: make Sergey's change to rebasing merges article
1 parent 9fb99e6 commit f29b4f5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

‎rev_news/drafts/edition-38.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,10 @@ did not work, as dropped commits could end up being replaid into the
7373
merge commits, turning them into "evil" merges.
7474

7575
Further suggestions to the strategy were proposed and tested,
76-
ultimately resulting in Sergey proposing the addition of using the
77-
original merge commit as a merge base during the final step.
76+
ultimately resulting in Sergey proposing
77+
[a fix to his method](https://public-inbox.org/git/[email protected]/),
78+
specifically using the original merge commit as a merge base during
79+
the final step.
7880

7981
Some discussion occurred about `merge -s ours` and how any rebasing
8082
strategy should avoid attempting to understand the semantics of the
@@ -86,7 +88,8 @@ the parent merge branch. This was immediately understood by Johannes
8688
and suggested as a potential for the default implementation.
8789

8890
Sergey replied that he thinks the solution produces the same result as
89-
his updated strategy.
91+
his updated strategy, at least when none of the strategies produce any
92+
conflicts.
9093

9194
Johannes suggested that he was open to using Phillip's strategy but
9295
was worried about syntax. He did not want to introduce inconsistent

0 commit comments

Comments
(0)