Merge pull request #16 from mike-perdide/master

Byron · Byron · commit 35bceb16480b · 2011-05-19T14:00:22.000-07:00
improved comparison between Object instances to check for compatibility of the other side first. Previously, and exception would be thrown.
This adds convenience in an area which probably is not performance critical.
diff --git a/git/objects/base.py b/git/objects/base.py
@@ -77,10 +77,14 @@ def _set_cache_(self, attr):
 		
 	def __eq__(self, other):
 		""":return: True if the objects have the same SHA1"""
+		if not hasattr(other, 'binsha'):
+			return False
 		return self.binsha == other.binsha
 		
 	def __ne__(self, other):
 		""":return: True if the objects do not have the same SHA1 """
+		if not hasattr(other, 'binsha'):
+			return True
 		return self.binsha != other.binsha
 		
 	def __hash__(self):

-Original file line number
+Diff line change
 def__eq__(self, other):
 """:return: True if the objects have the same SHA1"""
 +ifnothasattr(other, 'binsha'):
 +returnFalse
 returnself.binsha==other.binsha
 def__ne__(self, other):
 """:return: True if the objects do not have the same SHA1 """
 +ifnothasattr(other, 'binsha'):
 +returnTrue
 returnself.binsha!=other.binsha
 def__hash__(self):