Use uuid instead of tempfile.mkdtmp, which created an actual directory.

Byron · Byron · commit 5ac93b1d7e06 · 2015-02-19T16:56:13.000+01:00
That, over time, could have caused slow downs due to file-system hassle. Fixes #258
diff --git a/git/objects/submodule/base.py b/git/objects/submodule/base.py
@@ -37,7 +37,7 @@
 
 import os
 import logging
-import tempfile
+import uuid
 
 __all__ = ["Submodule", "UpdateProgress"]
 
@@ -992,7 +992,7 @@ def rename(self, new_name):
 source_dir = mod.git_dir
 # Let's be sure the submodule name is not so obviously tied to a directory
 if destination_module_abspath.startswith(mod.git_dir):
- tmp_dir = self._module_abspath(self.repo, self.path, os.path.basename(tempfile.mkdtemp()))
+ tmp_dir = self._module_abspath(self.repo, self.path, str(uuid.uuid4()))
 os.renames(source_dir, tmp_dir)
 source_dir = tmp_dir
 # end handle self-containment

-Original file line number
+Diff line change
 importos
 importlogging
 -importtempfile
 +importuuid
 __all__= ["Submodule", "UpdateProgress"]
 source_dir=mod.git_dir
 # Let's be sure the submodule name is not so obviously tied to a directory
 ifdestination_module_abspath.startswith(mod.git_dir):
 -tmp_dir=self._module_abspath(self.repo, self.path, os.path.basename(tempfile.mkdtemp()))
 +tmp_dir=self._module_abspath(self.repo, self.path, str(uuid.uuid4()))
 os.renames(source_dir, tmp_dir)
 source_dir=tmp_dir
 # end handle self-containment