Fix GitConfigParser not removing quotes from values

Author: betaboon

git/config.py

@@ -508,6 +508,8 @@ def string_decode(v: str) -> str:
 iflen(optval) >1andoptval[0] =='"'andoptval[-1] !='"':
 is_multi_line=True
 optval=string_decode(optval[1:])
+eliflen(optval) >1andoptval[0] =='"'andoptval[-1] =='"':
+optval=optval[1:-1].strip()
 # END handle multi-line
 # Preserves multiple values for duplicate optnames.
 cursect.add(optname, optval)

test/fixtures/git_config_with_quotes

@@ -0,0 +1,3 @@
+[user]
+ name = "Cody Veal"
+ email = "[email protected]"

test/test_config.py

@@ -391,7 +391,7 @@ def test_complex_aliases(self):
 withGitConfigParser(file_obj, read_only=False) asw_config:
 self.assertEqual(
 w_config.get("alias", "rbi"),
-'"!g(){git rebase -i origin/${1:-master} } ; g"',
+"!g(){git rebase -i origin/${1:-master} } ; g",
  )
 self.assertEqual(
 file_obj.getvalue(),
@@ -406,6 +406,12 @@ def test_empty_config_value(self):
 withself.assertRaises(cp.NoOptionError):
 cr.get_value("color", "ui")
 
+deftest_config_with_quotes(self):
+cr=GitConfigParser(fixture_path("git_config_with_quotes"), read_only=True)
+
+self.assertEqual(cr.get("user", "name"), "Cody Veal")
+self.assertEqual(cr.get("user", "email"), "[email protected]")
+
 deftest_get_values_works_without_requiring_any_other_calls_first(self):
 file_obj=self._to_memcache(fixture_path("git_config_multiple"))
 cr=GitConfigParser(file_obj, read_only=True)