Fix TypeError in git.execute(..., output_stream=file)

Dmitry Nikulin · Byron · commit b3d9b8df38da · 2018-08-05T13:56:21.000+02:00
This fixes #619 - raise GitCommandError(not TypeError) when output_stream is set in git.execute
diff --git a/git/cmd.py b/git/cmd.py
@@ -794,7 +794,7 @@ def _kill_process(pid):
 else:
 max_chunk_size = max_chunk_size if max_chunk_size and max_chunk_size > 0 else io.DEFAULT_BUFFER_SIZE
 stream_copy(proc.stdout, output_stream, max_chunk_size)
- stdout_value = output_stream
+ stdout_value = proc.stdout.read()
 stderr_value = proc.stderr.read()
 # strip trailing "\n"
 if stderr_value.endswith(b"\n"):

-Original file line number
+Diff line change
 else:
 max_chunk_size=max_chunk_sizeifmax_chunk_sizeandmax_chunk_size>0elseio.DEFAULT_BUFFER_SIZE
 stream_copy(proc.stdout, output_stream, max_chunk_size)
 -stdout_value=output_stream
 +stdout_value=proc.stdout.read()
 stderr_value=proc.stderr.read()
 # strip trailing "\n"
 ifstderr_value.endswith(b"\n"):