Closing file handles/streams

Author: craigez

git/cmd.py

@@ -382,6 +382,11 @@ def execute(self, command,
 finally:
 proc.stdout.close()
 proc.stderr.close()
+ifproc.stdin:
+proc.stdin.close()
+proc.poll()
+ifproc.returncodeisNone:
+proc.terminate()
 
 ifself.GIT_PYTHON_TRACE=='full':
 cmdstr=" ".join(command)

git/objects/commit.py

@@ -350,24 +350,31 @@ def _iter_from_process_or_stream(cls, odb, proc_or_stream):
  :param proc: git-rev-list process instance - one sha per line
  :return: iterator returning Commit objects"""
 stream=proc_or_stream
+close_std_err=False
 ifnothasattr(stream,'readline'):
 stream=proc_or_stream.stdout
+close_std_err=True
 
 readline=stream.readline
-whileTrue:
-line=readline()
-ifnotline:
-break
-hexsha=line.strip()
-iflen(hexsha) >40:
-# split additional information, as returned by bisect for instance
-hexsha, rest=line.split(None, 1)
-# END handle extra info
-
-assertlen(hexsha) ==40, "Invalid line: %s"%hexsha
-yieldcls(odb, hex_to_bin(hexsha))
-# END for each line in stream
-
+try:
+whileTrue:
+line=readline()
+ifnotline:
+break
+hexsha=line.strip()
+iflen(hexsha) >40:
+# split additional information, as returned by bisect for instance
+hexsha, rest=line.split(None, 1)
+# END handle extra info
+
+assertlen(hexsha) ==40, "Invalid line: %s"%hexsha
+yieldcls(odb, hex_to_bin(hexsha))
+# END for each line in stream
+finally:
+stream.close()
+ifclose_std_err:
+proc_or_stream.stderr.close()
+
 #{Serializable Implementation
 
 def_serialize(self, stream):