improve readability follows go-staticcheck (#1227)

zihengCat · web-flow · commit 21f789cd2353 · 2021-06-30T09:27:49.000+09:00
sign in AUTHORS
diff --git a/AUTHORS b/AUTHORS
@@ -101,6 +101,7 @@ Xiuming Chen <cc at cxm.cc>
 Xuehong Chan <chanxuehong at gmail.com>
 Zhenye Xie <xiezhenye at gmail.com>
 Zhixin Wen <john.wenzhixin at gmail.com>
+Ziheng Lyu <zihenglv at gmail.com>
 
 # Organizations
 
diff --git a/dsn.go b/dsn.go
@@ -426,7 +426,6 @@ func parseDSNParams(cfg *Config, params string) (err error){
 		// Collation
 		case "collation":
 			cfg.Collation = value
-			break
 
 		case "columnsWithAlias":
 			var isBool bool
diff --git a/statement_test.go b/statement_test.go
@@ -36,7 +36,7 @@ func TestConvertDerivedByteSlice(t *testing.T){
 		t.Fatal("Byte slice not convertible", err)
 	}
 
-	if bytes.Compare(output.([]byte), []byte("value")) != 0{
+	if !bytes.Equal(output.([]byte), []byte("value")){
 		t.Fatalf("Byte slice not converted, got %#v %T", output, output)
 	}
 }
diff --git a/utils.go b/utils.go
@@ -199,7 +199,7 @@ func parseByteYear(b []byte) (int, error){
 			return 0, err
 		}
 		year += v * n
-		n = n / 10
+		n /= 10
 	}
 	return year, nil
 }

-Original file line number
+Diff line change
 // Collation
 case"collation":
 cfg.Collation=value
 -break
 case"columnsWithAlias":
 varisBoolbool
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func TestConvertDerivedByteSlice(t *testing.T){`
`36`	`36`	`t.Fatal("Byte slice not convertible", err)`
`37`	`37`	`}`
`38`	`38`
`39`		`-ifbytes.Compare(output.([]byte), []byte("value"))!=0{`
	`39`	`+if!bytes.Equal(output.([]byte), []byte("value")){`
`40`	`40`	`t.Fatalf("Byte slice not converted, got %#v %T", output, output)`
`41`	`41`	`}`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ func parseByteYear(b []byte) (int, error){`
`199`	`199`	`return0, err`
`200`	`200`	`}`
`201`	`201`	`year+=v*n`
`202`		`-n=n/10`
	`202`	`+n/=10`
`203`	`203`	`}`
`204`	`204`	`returnyear, nil`
`205`	`205`	`}`