Remove unneeded calls to SQLiteDatabase.close

The SQLiteOpenHelper is always closed in a finally block and closing the database is handled there.

Author: kevinsawicki

app/src/main/java/com/github/mobile/persistence/DatabaseCache.java

@@ -126,16 +126,12 @@ private <E> List<E> requestAndStore(final SQLiteOpenHelper helper,
 if (db == null)
 returnitems;
 
+db.beginTransaction();
 try{
-db.beginTransaction();
-try{
-persistableResource.store(db, items);
-db.setTransactionSuccessful();
- } finally{
-db.endTransaction();
- }
+persistableResource.store(db, items);
+db.setTransactionSuccessful();
  } finally{
-db.close();
+db.endTransaction();
  }
 returnitems;
  }
@@ -146,22 +142,18 @@ private <E> List<E> loadFromDB(final SQLiteOpenHelper helper,
 if (db == null)
 returnnull;
 
+Cursorcursor = persistableResource.getCursor(db);
 try{
-Cursorcursor = persistableResource.getCursor(db);
-try{
-if (!cursor.moveToFirst())
-returnnull;
-
-List<E> cached = newArrayList<E>();
-do{
-cached.add(persistableResource.loadFrom(cursor));
- } while (cursor.moveToNext());
-returncached;
- } finally{
-cursor.close();
- }
+if (!cursor.moveToFirst())
+returnnull;
+
+List<E> cached = newArrayList<E>();
+do{
+cached.add(persistableResource.loadFrom(cursor));
+ } while (cursor.moveToNext());
+returncached;
  } finally{
-db.close();
+cursor.close();
  }
  }