Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository:swift-server/async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:main
Choose a base ref
...
head repository:iainsmith/async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Apr 13, 2020

  1. Enable clients to call URLs that include %2F as an escaped backslash

    Previously `percentEncodedPath` was using `path.addingPercentEncoding(withAllowedCharacters: .urlPathAllowed)` which converts %2F to a literal '/'. This prevented users fetching URLs like https://api.travis-ci.org/repo/github/rails%2Frails which use %2F as part of a path segment. Migrating to `URLComponents(url: self, resolvingAgainstBaseURL: false)?.percentEncodedPath` has the desired behaviour for the couple of test cases that exist. Updated the test server to switch on the `percentEncodedPath` so it's easier to understand the desired behaviour.
    @iainsmith
    iainsmith committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    efe6b5bView commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Remove redundant path manipulation related to trailing slashes.

    See - efe6b5b
    @iainsmith
    iainsmith committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    3950c95View commit details
    Browse the repository at this point in the history
Loading