Merge branch 'test_bridge' of https://github.com/fkromer/python-patterns into fkromer-test_bridge

Author: faif

test_bridge.py

@@ -13,7 +13,7 @@
 
 classBridgeTest(unittest.TestCase):
 
-deftest_bridge_shall_draw_with_concrete_implementation(cls):
+deftest_bridge_shall_draw_with_concrete_api_implementation(cls):
 ci1=DrawingAPI1()
 ci2=DrawingAPI2()
 withpatch.object(ci1, 'draw_circle') asmock_ci1_draw_circle,\
@@ -25,15 +25,27 @@ def test_bridge_shall_draw_with_concrete_implementation(cls):
 sh2.draw()
 cls.assertEqual(mock_ci2_draw_circle.call_count, 1)
 
-deftest_bridge_shall_scale_with_own_implementation(cls):
-ci=DrawingAPI1()
-sh=CircleShape(1, 2, 3, ci)
-sh.scale(2)
-cls.assertEqual(sh._radius, 6)
-withpatch.object(sh, 'scale') asmock_sh_scale_circle:
-sh.scale(2)
-cls.assertEqual(mock_sh_scale_circle.call_count, 1)
+deftest_bridge_shall_scale_both_api_circles_with_own_implementation(cls):
+SCALE_FACTOR=2
+CIRCLE_FACTOR=3
+CIRCLE1_RADIUS=3
+EXPECTED_CIRCLE1_RADIUS=6
+CIRCLE2_RADIUS=CIRCLE1_RADIUS*CIRCLE1_RADIUS
+EXPECTED_CIRCLE2_RADIUS=CIRCLE2_RADIUS*SCALE_FACTOR
+ci1=DrawingAPI1()
+ci2=DrawingAPI2()
+sh1=CircleShape(1, 2, CIRCLE1_RADIUS, ci1)
+sh2=CircleShape(1, 2, CIRCLE2_RADIUS, ci2)
+sh1.scale(SCALE_FACTOR)
+sh2.scale(SCALE_FACTOR)
+cls.assertEqual(sh1._radius, EXPECTED_CIRCLE1_RADIUS)
+cls.assertEqual(sh2._radius, EXPECTED_CIRCLE2_RADIUS)
+withpatch.object(sh1, 'scale') asmock_sh1_scale_circle,\
+patch.object(sh2, 'scale') asmock_sh2_scale_circle:
+sh1.scale(2)
+sh2.scale(2)
+cls.assertEqual(mock_sh1_scale_circle.call_count, 1)
+cls.assertEqual(mock_sh2_scale_circle.call_count, 1)
 
 if__name__=="__main__":
 unittest.main()
-