Merge pull request TooTallNate#1133 from marci4/Issue1132

marci4 · web-flow · commit d0f57313cb26 · 2021-03-25T20:43:52.000+01:00
Use SecureRandom instead of Random
diff --git a/src/main/java/org/java_websocket/drafts/Draft_6455.java b/src/main/java/org/java_websocket/drafts/Draft_6455.java
@@ -29,14 +29,14 @@
 import java.nio.ByteBuffer;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Locale;
-import java.util.Random;
 import java.util.TimeZone;
 import org.java_websocket.WebSocketImpl;
 import org.java_websocket.enums.CloseHandshakeType;
@@ -150,7 +150,7 @@ public class Draft_6455 extends Draft{
 /**
 * Attribute for the reusable random instance
 */
- private final Random reuseableRandom = new Random();
+ private final SecureRandom reuseableRandom = new SecureRandom();
 
 /**
 * Attribute for the maximum allowed size of a frame

-Original file line number
+Diff line change
 importjava.nio.ByteBuffer;
 importjava.security.MessageDigest;
 importjava.security.NoSuchAlgorithmException;
 +importjava.security.SecureRandom;
 importjava.text.SimpleDateFormat;
 importjava.util.ArrayList;
 importjava.util.Calendar;
 importjava.util.Collections;
 importjava.util.LinkedList;
 importjava.util.List;
 importjava.util.Locale;
 -importjava.util.Random;
 importjava.util.TimeZone;
 importorg.java_websocket.WebSocketImpl;
 importorg.java_websocket.enums.CloseHandshakeType;
 /**
  * Attribute for the reusable random instance
  */
 -privatefinalRandomreuseableRandom = newRandom();
 +privatefinalSecureRandomreuseableRandom = newSecureRandom();
 /**
  * Attribute for the maximum allowed size of a frame