Fix bug with data channel and audio monitor

DataChannel objects are copied when they are prepped for acquisition. Also, the copy constructor for DataChannel did not inherit the recording, enabled, or monitored state from the original when it is copied. Changing the state during acquisition resulted in changing the copy as desired, but not updating the original. Stopping acquisition and resuming would not be up to date with user configuration. Changing state before enabling acquisition would not propagate to the copy, because the copy constructor hardcoded the value. Both of these issues were changed in this commit. Since RecordNodes are handled in the same way, it is likely that this bug exists there too. However that behavior has not been changed yet.

Author: kmichaelfox

Source/Processors/Channel/InfoObjects.cpp

@@ -214,8 +214,8 @@ DataChannel::DataChannel(const DataChannel& ch)
  m_type(ch.m_type),
  m_bitVolts(ch.m_bitVolts),
  m_isEnabled(true),
- m_isMonitored(false),
- m_isRecording(false)
+ m_isMonitored(ch.m_isMonitored),
+ m_isRecording(ch.m_isRecording)
 {
 }
 
@@ -683,4 +683,4 @@ void ConfigurationObject::setDefaultNameAndDescription()
 {
 setName("Configuration Object");
 setDescription("Generic configuration object"); 
-}
+}

Source/Processors/Editors/ChannelSelector.cpp

@@ -655,19 +655,19 @@ void ChannelSelector::buttonClicked(Button* button)
 bool status = b->getToggleState();
 
 // std::cout << "Requesting audio monitor for channel " << ch->nodeIndex + 1 << std::endl;
-
-if (acquisitionIsActive) // use setParameter to change parameter safely
+
+// change parameter directly on editor
+// This is another of those ugly things that will go away once the
+// probe audio system is implemented, but is needed to maintain compatibility
+// between the older recording system and the newer channel objects.
+const_cast<DataChannel*>(ch)->setMonitored(status);
+
+
+if (acquisitionIsActive) // use setParameter to change audio node's copy of parameter safely, if running
 {
 AccessClass::getProcessorGraph()->
 getAudioNode()->setChannelStatus(ch, status);
  }
-else// change parameter directly
-{
-//This is another of those ugly things that will go away once the
-//probe audio system is implemented, but is needed to maintain compatibility
-//between the older recording system and the newer channel objects.
-const_cast<DataChannel*>(ch)->setMonitored(status);
- }
  }
 elseif (b->getType() == RECORD)
 {