Skip to content

Commit c7a1b85

Browse files
committed
Merge branch 'master' of https://github.com/git/git.github.io
2 parents ce9c307 + 97991c3 commit c7a1b85

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

‎rev_news/drafts/edition-53.md‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,34 +24,34 @@ This edition covers what happened during the month of June 2019.
2424

2525
### Reviews
2626

27-
*[easy bulk commit creation in tests](https://public-inbox.org/git/[email protected]/)
27+
*[Easy bulk commit creation in tests](https://public-inbox.org/git/[email protected]/)
2828

29-
Derrick Stolee, who prefers to be called Stolee, has sent
30-
[since September 2018](https://public-inbox.org/git/[email protected]/)
31-
"Git Test Coverage Report" emails to the mailing list.
29+
Derrick Stolee, who prefers to be called Stolee, has been sending
30+
"Git Test Coverage Report" emails to the mailing list
31+
[since September 2018](https://public-inbox.org/git/[email protected]/).
3232

33-
These emails contains reports made using `contrib/coverage-diff.sh`
34-
to combine the gcov output from `make coverage-test ; make coverage-report`
33+
These emails contain reports made using `contrib/coverage-diff.sh`
34+
to combine the `gcov` output from `make coverage-test ; make coverage-report`
3535
with the output from `git diff A B` to discover _new_ lines of code that are
3636
not covered by the test suite.
3737

3838
In June 2019 Stolee sent
3939
[a new report](https://public-inbox.org/git/[email protected]/)
40-
that found that some new lines of code contributed by Jeff King,
40+
which stated that some new lines of code contributed by Jeff King,
4141
alias Peff, were not covered by any test. Peff replied that when
4242
running the test that exercises the surrounding code, we hit the early
4343
return above the lines that are not tested when there are fewer than
4444
100 commits to index.
4545

46-
One solution to that could be to create 100 commits, instead of just
47-
10, in the test, though that would make the test slower. Peff then
46+
One solution to that problem could be to create 100 commits, instead of just
47+
10, in the test, though that would slow down the test. Peff then
4848
concluded:
4949

5050
> It would be nice if we had a "test_commits_bulk" that used fast-import
5151
> to create larger numbers of commits.
5252
5353
A few hours later Peff replied to himself by sending a 6 patch long
54-
patch series that implements the `test_commit_bulk` function he
54+
patch series which implements the `test_commit_bulk` function he
5555
suggested.
5656

5757
In this patch series Peff converted a few places in the code to use
@@ -74,9 +74,9 @@ This edition covers what happened during the month of June 2019.
7474
# --start=<n>:
7575
# number commit messages from <n> (default: 1)
7676
# --message=<msg>:
77-
# use <msg> as the commit mesasge (default: "commit $n")
77+
# use <msg> as the commit message (default: "commit $n")
7878
# --filename=<fn>:
79-
# modify <fn> in each commit (default: $n.t)
79+
# modify <fn> in each commit (default: "$n.t")
8080
# --contents=<string>:
8181
# place <string> in each file (default: "content $n")
8282
# --id=<string>:
@@ -102,11 +102,11 @@ This edition covers what happened during the month of June 2019.
102102
`test_commit_bulk` to C code and integrate it as `test-tool commit-bulk`.
103103
But anyway Peff suggested 3 different ways to have only 1 process.
104104

105-
One of the way Peff suggested was to add a feature to fast-import to
105+
One of the ways Peff suggested was to add a feature to fast-import to
106106
say "build on top of ref X". Elijah Newren replied to Peff that such
107107
a feature already exists using something like `from refs/heads/branch^0`.
108108

109-
Peff thanked Elijah used the feature in a patch he attached that
109+
Peff thanked Elijah and used the feature in a patch he attached, which
110110
further reduces the number of processes used.
111111

112112
Ævar Arnfjörð Bjarmason also replied to Peff wondering if just
@@ -124,7 +124,7 @@ This edition covers what happened during the month of June 2019.
124124
turnaround, providing results from performance tests on Windows
125125
which were similar as those provided by Peff, and suggesting
126126
possible improvements to the `test_commit_bulk` function. These
127-
possible improvements were then discussed by Junio Hamano, the Git
127+
suggestions were then discussed by Junio Hamano, the Git
128128
maintainer, and Peff.
129129

130130
Junio, Ævar, Eric Sunshine and Gábor Szeder also discussed with Peff
@@ -136,8 +136,8 @@ This edition covers what happened during the month of June 2019.
136136
improvements that had been discussed. Junio discussed the
137137
implementation a bit further, but seemed happy with the patch series.
138138

139-
Peff sent [a version 3](https://public-inbox.org/git/[email protected]/)
140-
recenty which will hopefully be merged soon.
139+
Peff recently sent [a version 3](https://public-inbox.org/git/[email protected]/),
140+
which will hopefully be merged soon.
141141

142142
<!---
143143
### Support

0 commit comments

Comments
(0)