Make Error a persistent reference#32
Merged
+178 −106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A Napi::Error instance must hold a persistent reference to the JS error object so that it can escape from handle scopes when thrown as a C++ exception. Fixes: nodejs#31
Merged
boingoing approved these changes May 4, 2017
boingoing left a comment
boingoing left a comment There was a problem hiding this comment.
LGTM, just one question about the case where we encounter a failure to create a ref for the JavaScript error in the Error ctor.
| // Avoid infinite recursion in the failure case. | ||
| // Don't try to construct & throw another Error instance. | ||
| assert(status == napi_ok); |
There was a problem hiding this comment.
Should we cause a fatal error here to kill the process?
MemberAuthor
There was a problem hiding this comment.
Probably. See also a few other places in this Error class where error-handling code can't throw errors.
We'd need a napi_fatal_error() API or similar.
MemberAuthor
There was a problem hiding this comment.
I'll leave this the way it is for now. Fatal error discussion is at nodejs/abi-stable-node#232
This was referenced May 30, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Napi::Errorinstance must hold a persistent reference to the JS error object so that it can escape from handle scopes when thrown as a C++ exception.Fixes: #31