tls: null not valid as a renegotiate callback

Allow undefined as a callback, but do not allow null. PR-URL: #25929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: sam-github

lib/_tls_wrap.js

@@ -601,7 +601,7 @@ TLSSocket.prototype._init = function(socket, wrap){
 TLSSocket.prototype.renegotiate=function(options,callback){
 if(options===null||typeofoptions!=='object')
 thrownewERR_INVALID_ARG_TYPE('options','Object',options);
-if(callback!=null&&typeofcallback!=='function')
+if(callback!==undefined&&typeofcallback!=='function')
 thrownewERR_INVALID_CALLBACK();
 
 if(this.destroyed)

test/parallel/test-tls-disable-renegotiation.js

@@ -63,6 +63,12 @@ server.listen(0, common.mustCall(() =>{
 type: TypeError,
 });
 
+common.expectsError(()=>client.renegotiate({},null),{
+code: 'ERR_INVALID_CALLBACK',
+type: TypeError,
+});
+
+
 // Negotiation is still permitted for this first
 // attempt. This should succeed.
 letok=client.renegotiate(options,common.mustCall((err)=>{