lib: add support for inherited custom inspection methods

aduh95 · RafaelGSS · commit 0162a0f5bf24 · 2023-07-03T10:32:48.000-03:00
PR-URL: #48306 Fixes: #48207 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/error_serdes.js b/lib/internal/error_serdes.js
@@ -13,7 +13,6 @@ const{
 ObjectGetOwnPropertyNames,
 ObjectGetPrototypeOf,
 ObjectKeys,
- ObjectPrototypeHasOwnProperty,
 ObjectPrototypeToString,
 RangeError,
 ReferenceError,
@@ -134,8 +133,7 @@ function serializeError(error){
 // Continue regardless of error.
 }
 try{
- if (error != null &&
- ObjectPrototypeHasOwnProperty(error, customInspectSymbol)){
+ if (error != null && customInspectSymbol in error){
 return Buffer.from(StringFromCharCode(kCustomInspectedObject) + inspect(error), 'utf8');
 }
 } catch{
diff --git a/test/parallel/test-error-serdes.js b/test/parallel/test-error-serdes.js
@@ -125,3 +125,11 @@ const data ={
 }
 };
 assert.strictEqual(inspect(cycle(data)), 'barbaz');
+
+const inheritedCustomInspect = new class{
+ foo = 'bar';
+ [inspect.custom](){
+ return 'barbaz';
+ }
+}();
+assert.strictEqual(inspect(cycle(inheritedCustomInspect)), 'barbaz');

-Original file line number
+Diff line change
+}
 };
 assert.strictEqual(inspect(cycle(data)),'barbaz');
++
 +constinheritedCustomInspect=newclass{
 +foo='bar';
 +[inspect.custom](){
 +return'barbaz';
 +}
 +}();
 +assert.strictEqual(inspect(cycle(inheritedCustomInspect)),'barbaz');