test: clean up dgram-broadcast-multi-process test

Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var. PR-URL: #9308 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: iredelmeier

test/internet/test-dgram-broadcast-multi-process.js

@@ -20,15 +20,17 @@ if (common.inFreeBSDJail){
 return;
 }
 
+letbindAddress=null;
+
 // Take the first non-internal interface as the address for binding.
 // Ideally, this should check for whether or not an interface is set up for
 // BROADCAST and favor internal/private interfaces.
-get_bindAddress: for(varnameinnetworkInterfaces){
-varinterfaces=networkInterfaces[name];
-for(vari=0;i<interfaces.length;i++){
-varlocalInterface=interfaces[i];
+get_bindAddress: for(constnameinnetworkInterfaces){
+constinterfaces=networkInterfaces[name];
+for(leti=0;i<interfaces.length;i++){
+constlocalInterface=interfaces[i];
 if(!localInterface.internal&&localInterface.family==='IPv4'){
-varbindAddress=localInterface.address;
+bindAddress=localInterface.address;
 break get_bindAddress;
 }
 }
@@ -56,9 +58,9 @@ if (process.argv[2] !== 'child'){
 },TIMEOUT);
 
 //launch child processes
-for(varx=0;x<listeners;x++){
+for(letx=0;x<listeners;x++){
 (function(){
-varworker=fork(process.argv[1],['child']);
+constworker=fork(process.argv[1],['child']);
 workers[worker.pid]=worker;
 
 worker.messagesReceived=[];
@@ -68,7 +70,7 @@ if (process.argv[2] !== 'child'){
 // don't consider this the true death if the worker
 // has finished successfully
 // or if the exit code is 0
-if(worker.isDone||code==0){
+if(worker.isDone||code===0){
 return;
 }
 
@@ -113,12 +115,12 @@ if (process.argv[2] !== 'child'){
 'messages. Will now compare.');
 
 Object.keys(workers).forEach(function(pid){
-varworker=workers[pid];
+constworker=workers[pid];
 
-varcount=0;
+letcount=0;
 
 worker.messagesReceived.forEach(function(buf){
-for(vari=0;i<messages.length;++i){
+for(leti=0;i<messages.length;++i){
 if(buf.toString()===messages[i].toString()){
 count++;
 break;
@@ -130,8 +132,11 @@ if (process.argv[2] !== 'child'){
 worker.pid,
 count);
 
-assert.equal(count,messages.length,
-'A worker received an invalid multicast message');
+assert.strictEqual(
+count,
+messages.length,
+'A worker received an invalid multicast message'
+);
 });
 
 clearTimeout(timer);
@@ -143,7 +148,7 @@ if (process.argv[2] !== 'child'){
 })(x);
 }
 
-varsendSocket=dgram.createSocket({
+constsendSocket=dgram.createSocket({
 type: 'udp4',
 reuseAddr: true
 });
@@ -160,7 +165,7 @@ if (process.argv[2] !== 'child'){
 });
 
 sendSocket.sendNext=function(){
-varbuf=messages[i++];
+constbuf=messages[i++];
 
 if(!buf){
 try{sendSocket.close();}catch(e){}
@@ -186,15 +191,15 @@ if (process.argv[2] !== 'child'){
 
 functionkillChildren(children){
 Object.keys(children).forEach(function(key){
-varchild=children[key];
+constchild=children[key];
 child.kill();
 });
 }
 }
 
 if(process.argv[2]==='child'){
-varreceivedMessages=[];
-varlistenSocket=dgram.createSocket({
+constreceivedMessages=[];
+constlistenSocket=dgram.createSocket({
 type: 'udp4',
 reuseAddr: true
 });
@@ -212,7 +217,7 @@ if (process.argv[2] === 'child'){
 
 process.send({message: buf.toString()});
 
-if(receivedMessages.length==messages.length){
+if(receivedMessages.length===messages.length){
 process.nextTick(function(){
 listenSocket.close();
 });