test: allow out-of-order replies in dgram tests

Allow out of order replies in the flaky `test-dgram{-upd6,}-send-default-host.js` files by sorting the incoming replies after receiving them. PR-URL: #6607Fixes: #6577 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Author: addaleax

test/parallel/test-dgram-send-default-host.js

@@ -11,20 +11,26 @@ const toSend = [Buffer.alloc(256, 'x'),
 Buffer.alloc(256,'z'),
 'hello'];
 
-client.on('listening',function(){
+constreceived=[];
+
+client.on('listening',common.mustCall(()=>{
 client.send(toSend[0],0,toSend[0].length,common.PORT);
 client.send(toSend[1],common.PORT);
 client.send([toSend[2]],common.PORT);
 client.send(toSend[3],0,toSend[3].length,common.PORT);
-});
+}));
+
+client.on('message',common.mustCall((buf,info)=>{
+received.push(buf.toString());
 
-client.on('message',function(buf,info){
-constexpected=toSend.shift().toString();
-assert.ok(buf.toString()===expected,'message was received correctly');
+if(received.length===toSend.length){
+// The replies may arrive out of order -> sort them before checking.
+received.sort();
 
-if(toSend.length===0){
+constexpected=toSend.map(String).sort();
+assert.deepStrictEqual(received,expected);
 client.close();
 }
-});
+},toSend.length));
 
 client.bind(common.PORT);

test/parallel/test-dgram-udp6-send-default-host.js

@@ -11,26 +11,31 @@ if (!common.hasIPv6){
 
 constclient=dgram.createSocket('udp6');
 
-consttoSend=[newBuffer(256),newBuffer(256),newBuffer(256),'hello'];
+consttoSend=[Buffer.alloc(256,'x'),
+Buffer.alloc(256,'y'),
+Buffer.alloc(256,'z'),
+'hello'];
 
-toSend[0].fill('x');
-toSend[1].fill('y');
-toSend[2].fill('z');
+constreceived=[];
 
-client.on('listening',function(){
+client.on('listening',common.mustCall(()=>{
 client.send(toSend[0],0,toSend[0].length,common.PORT);
 client.send(toSend[1],common.PORT);
 client.send([toSend[2]],common.PORT);
 client.send(toSend[3],0,toSend[3].length,common.PORT);
-});
+}));
 
-client.on('message',function(buf,info){
-constexpected=toSend.shift().toString();
-assert.ok(buf.toString()===expected,'message was received correctly');
+client.on('message',common.mustCall((buf,info)=>{
+received.push(buf.toString());
 
-if(toSend.length===0){
+if(received.length===toSend.length){
+// The replies may arrive out of order -> sort them before checking.
+received.sort();
+
+constexpected=toSend.map(String).sort();
+assert.deepStrictEqual(received,expected);
 client.close();
 }
-});
+},toSend.length));
 
 client.bind(common.PORT);