benchmark, test: replace CRLF variable with string literal

PR-URL: #59466 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

Author: wlgh1553

benchmark/http/bench-parser.js

@@ -16,7 +16,6 @@ function main({len, n }){
 constkOnHeadersComplete=HTTPParser.kOnHeadersComplete|0;
 constkOnBody=HTTPParser.kOnBody|0;
 constkOnMessageComplete=HTTPParser.kOnMessageComplete|0;
-constCRLF='\r\n';
 
 functionprocessHeader(header,n){
 constparser=newParser(REQUEST);
@@ -43,12 +42,12 @@ function main({len, n }){
 returnparser;
 }
 
-letheader=`GET /hello HTTP/1.1${CRLF}Content-Type: text/plain${CRLF}`;
+letheader=`GET /hello HTTP/1.1\r\nContent-Type: text/plain\r\n`;
 
 for(leti=0;i<len;i++){
-header+=`X-Filler${i}: ${Math.random().toString(36).substring(2)}${CRLF}`;
+header+=`X-Filler${i}: ${Math.random().toString(36).substring(2)}\r\n`;
 }
-header+=CRLF;
+header+='\r\n';
 
 processHeader(Buffer.from(header),n);
 }

test/parallel/test-http-header-overflow.js

@@ -4,14 +4,13 @@ const assert = require('assert');
 const{ createServer, maxHeaderSize }=require('http');
 const{ createConnection }=require('net');
 
-constCRLF='\r\n';
 constDUMMY_HEADER_NAME='Cookie: ';
 constDUMMY_HEADER_VALUE='a'.repeat(
 // Plus one is to make it 1 byte too big
 maxHeaderSize-DUMMY_HEADER_NAME.length+1
 );
 constPAYLOAD_GET='GET /blah HTTP/1.1';
-constPAYLOAD=PAYLOAD_GET+CRLF+DUMMY_HEADER_NAME+DUMMY_HEADER_VALUE;
+constPAYLOAD=PAYLOAD_GET+'\r\n'+DUMMY_HEADER_NAME+DUMMY_HEADER_VALUE;
 
 constserver=createServer();
 

test/parallel/test-http-upgrade-client2.js

@@ -23,13 +23,11 @@
 constcommon=require('../common');
 consthttp=require('http');
 
-constCRLF='\r\n';
-
 constserver=http.createServer();
 server.on('upgrade',function(req,socket){
-socket.write(`HTTP/1.1 101 Ok${CRLF}`+
-`Connection: Upgrade${CRLF}`+
-`Upgrade: Test${CRLF}${CRLF}`+
+socket.write(`HTTP/1.1 101 Ok\r\n`+
+`Connection: Upgrade\r\n`+
+`Upgrade: Test\r\n\r\n`+
 'head');
 socket.on('end',function(){
 socket.end();

test/parallel/test-https-foafssl.js

@@ -47,7 +47,6 @@ const webIdUrl = 'URI:http://example.com/#me'
 constmodulus=fixtures.readKey('rsa_cert_foafssl_b.modulus','ascii').replace(/\n/g,'');
 constexponent=fixtures.readKey('rsa_cert_foafssl_b.exponent','ascii').replace(/\n/g,'');
 
-constCRLF='\r\n';
 constbody='hello world\n';
 letcert;
 
@@ -76,7 +75,7 @@ server.listen(0, function(){
 client.stdout.on('data',function(data){
 console.log('response received');
 constmessage=data.toString();
-constcontents=message.split(CRLF+CRLF).pop();
+constcontents=message.split('\r\n\r\n').pop();
 assert.strictEqual(body,contents);
 server.close((e)=>{
 assert.ifError(e);