src: use S_ISDIR to check if the file is a directory

PR-URL: #52164Fixes: #52159 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: theanarkh

src/node_file.cc

@@ -1151,7 +1151,7 @@ static void InternalModuleStat(const FunctionCallbackInfo<Value>& args){
 int rc = uv_fs_stat(env->event_loop(), &req, *path, nullptr);
 if (rc == 0){
 constuv_stat_t* const s = static_cast<constuv_stat_t*>(req.ptr);
- rc = !!(s->st_mode & S_IFDIR);
+ rc = S_ISDIR(s->st_mode);
  }
 uv_fs_req_cleanup(&req);
 
@@ -3079,7 +3079,7 @@ BindingData::FilePathIsFileReturnType BindingData::FilePathIsFile(
 
 if (rc == 0){
 constuv_stat_t* const s = static_cast<constuv_stat_t*>(req.ptr);
- rc = !!(s->st_mode & S_IFDIR);
+ rc = S_ISDIR(s->st_mode);
  }
 
 uv_fs_req_cleanup(&req);

src/permission/fs_permission.cc

@@ -20,7 +20,7 @@ std::string WildcardIfDir(const std::string& res) noexcept{
 int rc = uv_fs_stat(nullptr, &req, res.c_str(), nullptr);
 if (rc == 0){
 constuv_stat_t* const s = static_cast<constuv_stat_t*>(req.ptr);
-if (s->st_mode & S_IFDIR){
+if ((s->st_mode & S_IFMT) == S_IFDIR){
 // add wildcard when directory
 if (res.back() == node::kPathSeparator){
 return res + "*";

test/parallel/test-fs-readdir-recursive.js

@@ -0,0 +1,14 @@
+'use strict';
+constcommon=require('../common');
+constfs=require('fs');
+constnet=require('net');
+
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
+constserver=net.createServer().listen(common.PIPE,common.mustCall(()=>{
+// The process should not crash
+// See https://github.com/nodejs/node/issues/52159
+fs.readdirSync(tmpdir.path,{recursive: true});
+server.close();
+}));