test: remove common.fileExists()

common.fileExists() can be replaced with fs.existsSync(). PR-URL: #22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>

Author: Trott

test/common/README.md

@@ -121,12 +121,6 @@ Tests whether `name`, `expected`, and `code` are part of a raised warning. If
 an expected warning does not have a code then `common.noWarnCode` can be used
 to indicate this.
 
-### fileExists(pathname)
-* pathname [<string>]
-* return [<boolean>]
-
-Checks if `pathname` exists
-
 ### getArrayBufferViews(buf)
 *`buf`[<Buffer>]
 * return [<ArrayBufferView[]>]

test/common/index.js

@@ -477,17 +477,8 @@ exports.hasMultiLocalhost = function hasMultiLocalhost(){
 returnret===0;
 };
 
-exports.fileExists=function(pathname){
-try{
-fs.accessSync(pathname);
-returntrue;
-}catch(err){
-returnfalse;
-}
-};
-
 exports.skipIfEslintMissing=function(){
-if(!exports.fileExists(
+if(!fs.existsSync(
 path.join(__dirname,'..','..','tools','node_modules','eslint')
 )){
 exports.skip('missing ESLint');

test/common/index.mjs

@@ -33,7 +33,6 @@ const{
  mustCallAtLeast,
  mustCallAsync,
  hasMultiLocalhost,
- fileExists,
  skipIfEslintMissing,
  canCreateSymLink,
  getCallSite,
@@ -92,7 +91,6 @@ export{
 mustCallAtLeast,
 mustCallAsync,
 hasMultiLocalhost,
-fileExists,
 skipIfEslintMissing,
 canCreateSymLink,
 getCallSite,

test/parallel/test-child-process-spawn-error.js

@@ -23,10 +23,11 @@
 constcommon=require('../common');
 constspawn=require('child_process').spawn;
 constassert=require('assert');
+constfs=require('fs');
 
 constenoentPath='foo123';
 constspawnargs=['bar'];
-assert.strictEqual(common.fileExists(enoentPath),false);
+assert.strictEqual(fs.existsSync(enoentPath),false);
 
 constenoentChild=spawn(enoentPath,spawnargs);
 enoentChild.on('error',common.mustCall(function(err){

test/parallel/test-fs-existssync-false.js

@@ -1,5 +1,5 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 consttmpdir=require('../common/tmpdir');
 
 // This test ensures that fs.existsSync doesn't incorrectly return false.
@@ -28,7 +28,7 @@ for (let i = 0; i < 50; i++){
 }
 
 // Test if file exists synchronously
-assert(common.fileExists(dir),'Directory is not accessible');
+assert(fs.existsSync(dir),'Directory is not accessible');
 
 // Test if file exists asynchronously
 fs.access(dir,function(err){

test/parallel/test-fs-mkdir-rmdir.js

@@ -10,19 +10,19 @@ const d = path.join(tmpdir.path, 'dir');
 tmpdir.refresh();
 
 // Make sure the directory does not exist
-assert(!common.fileExists(d));
+assert(!fs.existsSync(d));
 // Create the directory now
 fs.mkdirSync(d);
 // Make sure the directory exists
-assert(common.fileExists(d));
+assert(fs.existsSync(d));
 // Try creating again, it should fail with EEXIST
 assert.throws(function(){
 fs.mkdirSync(d);
 },/EEXIST:filealreadyexists,mkdir/);
 // Remove the directory now
 fs.rmdirSync(d);
 // Make sure the directory does not exist
-assert(!common.fileExists(d));
+assert(!fs.existsSync(d));
 
 // Similarly test the Async version
 fs.mkdir(d,0o666,common.mustCall(function(err){

test/parallel/test-fs-mkdir.js

@@ -32,7 +32,7 @@ tmpdir.refresh();
 
 fs.mkdir(pathname,common.mustCall(function(err){
 assert.strictEqual(err,null);
-assert.strictEqual(common.fileExists(pathname),true);
+assert.strictEqual(fs.existsSync(pathname),true);
 }));
 }
 
@@ -41,7 +41,7 @@ tmpdir.refresh();
 
 fs.mkdir(pathname,0o777,common.mustCall(function(err){
 assert.strictEqual(err,null);
-assert.strictEqual(common.fileExists(pathname),true);
+assert.strictEqual(fs.existsSync(pathname),true);
 }));
 }
 
@@ -50,7 +50,7 @@ tmpdir.refresh();
 
 fs.mkdirSync(pathname);
 
-constexists=common.fileExists(pathname);
+constexists=fs.existsSync(pathname);
 assert.strictEqual(exists,true);
 }
 

test/parallel/test-fs-mkdtemp.js

@@ -11,16 +11,16 @@ tmpdir.refresh();
 consttmpFolder=fs.mkdtempSync(path.join(tmpdir.path,'foo.'));
 
 assert.strictEqual(path.basename(tmpFolder).length,'foo.XXXXXX'.length);
-assert(common.fileExists(tmpFolder));
+assert(fs.existsSync(tmpFolder));
 
 constutf8=fs.mkdtempSync(path.join(tmpdir.path,'\u0222abc.'));
 assert.strictEqual(Buffer.byteLength(path.basename(utf8)),
 Buffer.byteLength('\u0222abc.XXXXXX'));
-assert(common.fileExists(utf8));
+assert(fs.existsSync(utf8));
 
 functionhandler(err,folder){
 assert.ifError(err);
-assert(common.fileExists(folder));
+assert(fs.existsSync(folder));
 assert.strictEqual(this,undefined);
 }
 

test/parallel/test-fs-symlink-dir-junction.js

@@ -47,8 +47,8 @@ fs.symlink(linkData, linkPath, 'junction', common.mustCall(function(err){
 
 fs.unlink(linkPath,common.mustCall(function(err){
 assert.ifError(err);
-assert(!common.fileExists(linkPath));
-assert(common.fileExists(linkData));
+assert(!fs.existsSync(linkPath));
+assert(fs.existsSync(linkData));
 }));
 }));
 }));

test/parallel/test-require-exceptions.js

@@ -20,8 +20,9 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
+constfs=require('fs');
 constfixtures=require('../common/fixtures');
 
 // A module with an error in it should throw
@@ -52,5 +53,5 @@ function assertModuleNotFound(path){
 }
 
 functionassertExists(fixture){
-assert(common.fileExists(fixtures.path(fixture)));
+assert(fs.existsSync(fixtures.path(fixture)));
 }