stream: avoid instanceof

mscdex · mscdex · commit 03b9f6fe2665 · 2017-01-11T12:55:04.000-05:00
PR-URL: #10558 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -284,9 +284,11 @@ function decodeChunk(state, chunk, encoding){
 // If we return false, then we need a drain event, so set that flag.
 function writeOrBuffer(stream, state, isBuf, chunk, encoding, cb){
 if (!isBuf){
- chunk = decodeChunk(state, chunk, encoding);
- if (chunk instanceof Buffer)
+ var newChunk = decodeChunk(state, chunk, encoding);
+ if (chunk !== newChunk){
 encoding = 'buffer';
+ chunk = newChunk;
+ }
 }
 var len = state.objectMode ? 1 : chunk.length;
 

-Original file line number
+Diff line change
 // If we return false, then we need a drain event, so set that flag.
 functionwriteOrBuffer(stream,state,isBuf,chunk,encoding,cb){
 if(!isBuf){
 -chunk=decodeChunk(state,chunk,encoding);
 -if(chunkinstanceofBuffer)
 +varnewChunk=decodeChunk(state,chunk,encoding);
 +if(chunk!==newChunk){
 encoding='buffer';
 +chunk=newChunk;
 +}
+}
 varlen=state.objectMode ? 1 : chunk.length;