https: prevent options object from being mutated

Previously, when passing options object to the agent.createConnection method, the same options object got modified within the method. Now, any modification will happen on only a copy of the object. Fixes: #31119 PR-URL: #31151 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: vighnesh153

lib/https.js

@@ -96,9 +96,11 @@ function createConnection(port, host, options){
 if(port!==null&&typeofport==='object'){
 options=port;
 }elseif(host!==null&&typeofhost==='object'){
-options=host;
+options={ ...host};
 }elseif(options===null||typeofoptions!=='object'){
 options={};
+}else{
+options={ ...options};
 }
 
 if(typeofport==='number'){

test/parallel/test-https-agent-create-connection.js

@@ -132,3 +132,27 @@ function createServer(){
 }));
 }));
 }
+
+// `options` should not be modified
+{
+constserver=createServer();
+server.listen(0,common.mustCall(()=>{
+constport=server.address().port;
+consthost='localhost';
+constoptions={
+port: 3000,
+rejectUnauthorized: false
+};
+
+constsocket=agent.createConnection(port,host,options);
+socket.on('connect',common.mustCall((data)=>{
+socket.end();
+}));
+socket.on('end',common.mustCall(()=>{
+assert.deepStrictEqual(options,{
+port: 3000,rejectUnauthorized: false
+});
+server.close();
+}));
+}));
+}