test: remove common.fail()

common.fail() was added to paste over issues with assert.fail() function signature. assert.fail() has been updated to accept a single argument so common.fail() is no longer necessary. PR-URL: #12293 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Trott

test/README.md

@@ -246,12 +246,6 @@ Checks whether `IPv6` is supported on this platform.
 
 Checks if there are multiple localhosts available.
 
-### fail(msg)
-*`msg`[<String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type)
-* return [<Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)
-
-Throws an `AssertionError` with `msg`
-
 ### fileExists(pathname)
 * pathname [<String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type)
 * return [<Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)

test/common.js

@@ -404,7 +404,7 @@ process.on('exit', function(){
 if(!exports.globalCheck)return;
 constleaked=leakedGlobals();
 if(leaked.length>0){
-fail(`Unexpected global(s) found: ${leaked.join(', ')}`);
+assert.fail(`Unexpected global(s) found: ${leaked.join(', ')}`);
 }
 });
 
@@ -507,14 +507,9 @@ exports.canCreateSymLink = function(){
 returntrue;
 };
 
-functionfail(msg){
-assert.fail(null,null,msg);
-}
-exports.fail=fail;
-
 exports.mustNotCall=function(msg){
 returnfunctionmustNotCall(){
-fail(msg||'function should not have been called');
+assert.fail(msg||'function should not have been called');
 };
 };
 
@@ -627,7 +622,7 @@ exports.WPT ={
 },
 assert_array_equals: assert.deepStrictEqual,
 assert_unreached(desc){
-assert.fail(undefined,undefined,`Reached unreachable code: ${desc}`);
+assert.fail(`Reached unreachable code: ${desc}`);
 }
 };
 

test/inspector/inspector-helper.js

@@ -217,7 +217,7 @@ TestSession.prototype.sendInspectorCommands = function(commands){
 for(constidinthis.messages_){
 s+=id+', ';
 }
-common.fail('Messages without response: '+
+assert.fail('Messages without response: '+
 s.substring(0,s.length-2));
 },TIMEOUT);
 });

test/internet/test-dgram-send-cb-quelches-error.js

@@ -28,7 +28,7 @@ function callbackOnly(err){
 }
 
 functiononEvent(err){
-common.fail('Error should not be emitted if there is callback');
+assert.fail('Error should not be emitted if there is callback');
 }
 
 functiononError(err){

test/internet/test-dns.js

@@ -453,7 +453,7 @@ TEST(function test_lookup_all_mixed(done){
 elseif(isIPv6(ip.address))
 assert.strictEqual(ip.family,6);
 else
-common.fail('unexpected IP address');
+assert.fail('unexpected IP address');
 });
 
 done();

test/internet/test-tls-add-ca-cert.js

@@ -38,7 +38,7 @@ tls.connect(opts, fail).on('error', common.mustCall((err) =>{
 }));
 
 functionfail(){
-common.fail('should fail to connect');
+assert.fail('should fail to connect');
 }
 
 // New secure contexts have the well-known root CAs.

test/parallel/test-beforeexit-event-exit.js

@@ -20,10 +20,11 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-constcommon=require('../common');
+require('../common');
+constassert=require('assert');
 
 process.on('beforeExit',function(){
-common.fail('exit should not allow this to occur');
+assert.fail('exit should not allow this to occur');
 });
 
 process.exit();

test/parallel/test-child-process-fork-and-spawn.js

@@ -37,7 +37,7 @@ switch (process.argv[2] || ''){
 case'spawn':
 break;
 default:
-common.fail();
+assert.fail();
 }
 
 functioncheckExit(statusCode){

test/parallel/test-child-process-stdout-flush-exit.js

@@ -42,7 +42,7 @@ if (process.argv[2] === 'child'){
 
 child.stderr.setEncoding('utf8');
 child.stderr.on('data',function(data){
-common.fail(`Unexpected parent stderr: ${data}`);
+assert.fail(`Unexpected parent stderr: ${data}`);
 });
 
 // check if we receive both 'hello' at start and 'goodbye' at end

test/parallel/test-cluster-send-handle-twice.js

@@ -51,7 +51,7 @@ if (cluster.isMaster){
 setTimeout(function(){client.end();},50);
 }).on('error',function(e){
 console.error(e);
-common.fail('server.listen failed');
+assert.fail('server.listen failed');
 cluster.worker.disconnect();
 });
 }