crypto: handle OpenSSL error queue in CipherBase

This handles all errors produced by OpenSSL within the CipherBase class. API functions ensure that they do not add any new errors to the error queue. Also adds a couple of CHECKs and throws under certain conditions. PR-URL: #21288Fixes: #21281 Refs: #21287 Reviewed-By: Ujjwal Sharma <[email protected]>

Author: tniessen

src/node_crypto.cc

@@ -2581,6 +2581,7 @@ void CipherBase::Init(const char* cipher_type,
 int key_buf_len,
 unsignedint auth_tag_len){
  HandleScope scope(env()->isolate());
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 
 #ifdef NODE_FIPS_MODE
 if (FIPS_mode()){
@@ -2605,6 +2606,7 @@ void CipherBase::Init(const char* cipher_type,
 1,
  key,
  iv);
+CHECK_NE(key_len, 0);
 
  ctx_.reset(EVP_CIPHER_CTX_new());
 
@@ -2613,7 +2615,11 @@ void CipherBase::Init(const char* cipher_type,
 EVP_CIPHER_CTX_set_flags(ctx_.get(), EVP_CIPHER_CTX_FLAG_WRAP_ALLOW);
 
 constbool encrypt = (kind_ == kCipher);
-EVP_CipherInit_ex(ctx_.get(), cipher, nullptr, nullptr, nullptr, encrypt);
+if (1 != EVP_CipherInit_ex(ctx_.get(), cipher, nullptr,
+nullptr, nullptr, encrypt)){
+returnThrowCryptoError(env(), ERR_get_error(),
+"Failed to initialize cipher");
+ }
 
 if (encrypt && (mode == EVP_CIPH_CTR_MODE || mode == EVP_CIPH_GCM_MODE ||
  mode == EVP_CIPH_CCM_MODE)){
@@ -2632,12 +2638,15 @@ void CipherBase::Init(const char* cipher_type,
 
 CHECK_EQ(1, EVP_CIPHER_CTX_set_key_length(ctx_.get(), key_len));
 
-EVP_CipherInit_ex(ctx_.get(),
-nullptr,
-nullptr,
-reinterpret_cast<unsignedchar*>(key),
-reinterpret_cast<unsignedchar*>(iv),
- encrypt);
+if (1 != EVP_CipherInit_ex(ctx_.get(),
+nullptr,
+nullptr,
+reinterpret_cast<unsignedchar*>(key),
+reinterpret_cast<unsignedchar*>(iv),
+ encrypt)){
+returnThrowCryptoError(env(), ERR_get_error(),
+"Failed to initialize cipher");
+ }
 }
 
 
@@ -2672,6 +2681,7 @@ void CipherBase::InitIv(const char* cipher_type,
 int iv_len,
 unsignedint auth_tag_len){
  HandleScope scope(env()->isolate());
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 
 const EVP_CIPHER* const cipher = EVP_get_cipherbyname(cipher_type);
 if (cipher == nullptr){
@@ -2702,7 +2712,11 @@ void CipherBase::InitIv(const char* cipher_type,
 EVP_CIPHER_CTX_set_flags(ctx_.get(), EVP_CIPHER_CTX_FLAG_WRAP_ALLOW);
 
 constbool encrypt = (kind_ == kCipher);
-EVP_CipherInit_ex(ctx_.get(), cipher, nullptr, nullptr, nullptr, encrypt);
+if (1 != EVP_CipherInit_ex(ctx_.get(), cipher, nullptr,
+nullptr, nullptr, encrypt)){
+returnThrowCryptoError(env(), ERR_get_error(),
+"Failed to initialize cipher");
+ }
 
 if (IsAuthenticatedMode()){
 CHECK(has_iv);
@@ -2715,12 +2729,15 @@ void CipherBase::InitIv(const char* cipher_type,
 returnenv()->ThrowError("Invalid key length");
  }
 
-EVP_CipherInit_ex(ctx_.get(),
-nullptr,
-nullptr,
-reinterpret_cast<constunsignedchar*>(key),
-reinterpret_cast<constunsignedchar*>(iv),
- encrypt);
+if (1 != EVP_CipherInit_ex(ctx_.get(),
+nullptr,
+nullptr,
+reinterpret_cast<constunsignedchar*>(key),
+reinterpret_cast<constunsignedchar*>(iv),
+ encrypt)){
+returnThrowCryptoError(env(), ERR_get_error(),
+"Failed to initialize cipher");
+ }
 }
 
 
@@ -2765,6 +2782,7 @@ static bool IsValidGCMTagLength(unsigned int tag_len){
 boolCipherBase::InitAuthenticated(constchar* cipher_type, int iv_len,
 unsignedint auth_tag_len){
 CHECK(IsAuthenticatedMode());
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 
 if (!EVP_CIPHER_CTX_ctrl(ctx_.get(),
  EVP_CTRL_AEAD_SET_IVLEN,
@@ -2910,6 +2928,7 @@ void CipherBase::SetAuthTag(const FunctionCallbackInfo<Value>& args){
 boolCipherBase::SetAAD(constchar* data, unsignedint len, int plaintext_len){
 if (!ctx_ || !IsAuthenticatedMode())
 returnfalse;
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 
 int outlen;
 constint mode = EVP_CIPHER_CTX_mode(ctx_.get());
@@ -2969,6 +2988,7 @@ CipherBase::UpdateResult CipherBase::Update(const char* data,
 int* out_len){
 if (!ctx_)
 returnkErrorState;
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 
 constint mode = EVP_CIPHER_CTX_mode(ctx_.get());
 
@@ -2980,10 +3000,10 @@ CipherBase::UpdateResult CipherBase::Update(const char* data,
 // on first update:
 if (kind_ == kDecipher && IsAuthenticatedMode() && auth_tag_len_ > 0 &&
  auth_tag_len_ != kNoAuthTagLength && !auth_tag_set_){
-EVP_CIPHER_CTX_ctrl(ctx_.get(),
- EVP_CTRL_GCM_SET_TAG,
- auth_tag_len_,
-reinterpret_cast<unsignedchar*>(auth_tag_));
+CHECK(EVP_CIPHER_CTX_ctrl(ctx_.get(),
+EVP_CTRL_GCM_SET_TAG,
+auth_tag_len_,
+reinterpret_cast<unsignedchar*>(auth_tag_)));
  auth_tag_set_ = true;
  }
 
@@ -3061,6 +3081,7 @@ void CipherBase::Update(const FunctionCallbackInfo<Value>& args){
 boolCipherBase::SetAutoPadding(bool auto_padding){
 if (!ctx_)
 returnfalse;
+ MarkPopErrorOnReturn mark_pop_error_on_return;
 returnEVP_CIPHER_CTX_set_padding(ctx_.get(), auto_padding);
 }