esm: improve error when calling import.meta.resolve from data: URL

PR-URL: #49516 Reviewed-By: James M Snell <[email protected]>

Author: aduh95

doc/api/errors.md

@@ -2956,6 +2956,26 @@ import 'package-name' // supported
 
 `import` with URL schemes other than `file` and `data` is unsupported.
 
+<aid="ERR_UNSUPPORTED_RESOLVE_REQUEST"></a>
+
+### `ERR_UNSUPPORTED_RESOLVE_REQUEST`
+
+An attempt was made to resolve an invalid module referrer. This can happen when
+importing or calling `import.meta.resolve()` with either:
+
+* a bare specifier that is not a builtin module from a module whose URL scheme
+ is not `file`.
+* a [relative URL][] from a module whose URL scheme is not a [special scheme][].
+
+```mjs
+try{
+// Trying to import the package 'bare-specifier' from a `data:` URL module:
+awaitimport('data:text/javascript,import "bare-specifier"');
+} catch (e){
+console.log(e.code); // ERR_UNSUPPORTED_RESOLVE_REQUEST
+}
+```
+
 <aid="ERR_USE_AFTER_CLOSE"></a>
 
 ### `ERR_USE_AFTER_CLOSE`
@@ -3719,7 +3739,9 @@ The native call from `process.cpuUsage` could not be processed.
 [event emitter-based]: events.md#class-eventemitter
 [file descriptors]: https://en.wikipedia.org/wiki/File_descriptor
 [policy]: permissions.md#policies
+[relative URL]: https://url.spec.whatwg.org/#relative-url-string
 [self-reference a package using its name]: packages.md#self-referencing-a-package-using-its-name
+[special scheme]: https://url.spec.whatwg.org/#special-scheme
 [stream-based]: stream.md
 [syscall]: https://man7.org/linux/man-pages/man2/syscalls.2.html
 [try-catch]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/try...catch

lib/internal/errors.js

@@ -1863,6 +1863,9 @@ E('ERR_UNSUPPORTED_ESM_URL_SCHEME', (url, supported) =>{
 msg+=`. Received protocol '${url.protocol}'`;
 returnmsg;
 },Error);
+E('ERR_UNSUPPORTED_RESOLVE_REQUEST',
+'Failed to resolve module specifier "%s" from "%s": Invalid relative URL or base scheme is not hierarchical.',
+TypeError);
 E('ERR_USE_AFTER_CLOSE','%s was closed',Error);
 
 // This should probably be a `TypeError`.

lib/internal/modules/esm/resolve.js

@@ -37,7 +37,7 @@ const experimentalNetworkImports =
 getOptionValue('--experimental-network-imports');
 constinputTypeFlag=getOptionValue('--input-type');
 const{URL, pathToFileURL, fileURLToPath, isURL }=require('internal/url');
-const{ getCWDURL }=require('internal/util');
+const{ getCWDURL, setOwnProperty}=require('internal/util');
 const{canParse: URLCanParse}=internalBinding('url');
 const{legacyMainResolve: FSLegacyMainResolve}=internalBinding('fs');
 const{
@@ -51,6 +51,7 @@ const{
 ERR_PACKAGE_IMPORT_NOT_DEFINED,
 ERR_PACKAGE_PATH_NOT_EXPORTED,
 ERR_UNSUPPORTED_DIR_IMPORT,
+ERR_UNSUPPORTED_RESOLVE_REQUEST,
 ERR_NETWORK_IMPORT_DISALLOWED,
 }=require('internal/errors').codes;
 
@@ -884,22 +885,37 @@ function shouldBeTreatedAsRelativeOrAbsolutePath(specifier){
  * @param{boolean} preserveSymlinks - Whether to preserve symlinks in the resolved URL.
  */
 functionmoduleResolve(specifier,base,conditions,preserveSymlinks){
-constisRemote=base.protocol==='http:'||
-base.protocol==='https:';
+constprotocol=typeofbase==='string' ?
+StringPrototypeSlice(base,0,StringPrototypeIndexOf(base,':')+1) :
+base.protocol;
+constisData=protocol==='data:';
+constisRemote=
+isData||
+protocol==='http:'||
+protocol==='https:';
 // Order swapped from spec for minor perf gain.
 // Ok since relative URLs cannot parse as URLs.
 letresolved;
 if(shouldBeTreatedAsRelativeOrAbsolutePath(specifier)){
-resolved=newURL(specifier,base);
-}elseif(!isRemote&&specifier[0]==='#'){
+try{
+resolved=newURL(specifier,base);
+}catch(cause){
+consterror=newERR_UNSUPPORTED_RESOLVE_REQUEST(specifier,base);
+setOwnProperty(error,'cause',cause);
+throwerror;
+}
+}elseif(protocol==='file:'&&specifier[0]==='#'){
 resolved=packageImportsResolve(specifier,base,conditions);
 }else{
 try{
 resolved=newURL(specifier);
-}catch{
-if(!isRemote){
-resolved=packageResolve(specifier,base,conditions);
+}catch(cause){
+if(isRemote&&!BuiltinModule.canBeRequiredWithoutScheme(specifier)){
+consterror=newERR_UNSUPPORTED_RESOLVE_REQUEST(specifier,base);
+setOwnProperty(error,'cause',cause);
+throwerror;
 }
+resolved=packageResolve(specifier,base,conditions);
 }
 }
 if(resolved.protocol!=='file:'){
@@ -1073,7 +1089,7 @@ function defaultResolve(specifier, context ={}){
 }
 }
 
-letparsed;
+letparsed,protocol;
 try{
 if(shouldBeTreatedAsRelativeOrAbsolutePath(specifier)){
 parsed=newURL(specifier,parsedParentURL);
@@ -1082,7 +1098,7 @@ function defaultResolve(specifier, context ={}){
 }
 
 // Avoid accessing the `protocol` property due to the lazy getters.
-constprotocol=parsed.protocol;
+protocol=parsed.protocol;
 if(protocol==='data:'||
 (experimentalNetworkImports&&
 (
@@ -1109,7 +1125,8 @@ function defaultResolve(specifier, context ={}){
 if(maybeReturn){returnmaybeReturn;}
 
 // This must come after checkIfDisallowedImport
-if(parsed&&parsed.protocol==='node:'){return{__proto__: null,url: specifier};}
+protocol??=parsed?.protocol;
+if(protocol==='node:'){return{__proto__: null,url: specifier};}
 
 
 constisMain=parentURL===undefined;

test/es-module/test-esm-import-meta-resolve.mjs

@@ -36,6 +36,28 @@ assert.strictEqual(import.meta.resolve('http://some-absolute/url'), 'http://some
 assert.strictEqual(import.meta.resolve('some://weird/protocol'),'some://weird/protocol');
 assert.strictEqual(import.meta.resolve('baz/',fixtures),
 fixtures+'node_modules/baz/');
+assert.deepStrictEqual(
+{ ...awaitimport('data:text/javascript,export default import.meta.resolve("http://some-absolute/url")')},
+{default: 'http://some-absolute/url'},
+);
+assert.deepStrictEqual(
+{ ...awaitimport('data:text/javascript,export default import.meta.resolve("some://weird/protocol")')},
+{default: 'some://weird/protocol'},
+);
+assert.deepStrictEqual(
+{ ...awaitimport(`data:text/javascript,export default import.meta.resolve("baz/", ${JSON.stringify(fixtures)})`)},
+{default: fixtures+'node_modules/baz/'},
+);
+assert.deepStrictEqual(
+{ ...awaitimport('data:text/javascript,export default import.meta.resolve("fs")')},
+{default: 'node:fs'},
+);
+awaitassert.rejects(import('data:text/javascript,export default import.meta.resolve("does-not-exist")'),{
+code: 'ERR_UNSUPPORTED_RESOLVE_REQUEST',
+});
+awaitassert.rejects(import('data:text/javascript,export default import.meta.resolve("./relative")'),{
+code: 'ERR_UNSUPPORTED_RESOLVE_REQUEST',
+});
 
 {
 constcp=spawn(execPath,[