src: fix build break for !NODE_USE_V8_PLATFORM

kunalspathak · evanlucas · commit 091ba2c511a1 · 2016-08-20T10:02:15.000-05:00
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: #8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/src/node.cc b/src/node.cc
@@ -221,8 +221,9 @@ static struct{
 void Initialize(int thread_pool_size){}
 void PumpMessageLoop(Isolate* isolate){}
 void Dispose(){}
- void StartInspector(Environment *env, int port, bool wait){
+ bool StartInspector(Environment *env, int port, bool wait){
 env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
+ return false; // make compiler happy
 }
 #endif // !NODE_USE_V8_PLATFORM
 } v8_platform;

-Original file line number
+Diff line change
 voidInitialize(int thread_pool_size){}
 voidPumpMessageLoop(Isolate* isolate){}
 voidDispose(){}
 -voidStartInspector(Environment *env, int port, bool wait){
 +boolStartInspector(Environment *env, int port, bool wait){
  env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
 +returnfalse; // make compiler happy
+ }
 #endif// !NODE_USE_V8_PLATFORM
 } v8_platform;