lib: use static Number properties from primordials

PR-URL: #30686 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: targos

lib/_http_client.js

@@ -24,6 +24,7 @@
 const{
  ArrayIsArray,
  Boolean,
+ NumberIsFinite,
  ObjectAssign,
  ObjectKeys,
  ObjectSetPrototypeOf,
@@ -219,7 +220,7 @@ function ClientRequest(input, options, cb){
 // but only if the Agent will actually reuse the connection!
 // If it's not a keepAlive agent, and the maxSockets==Infinity, then
 // there's never a case where this socket will actually be reused
-if(!this.agent.keepAlive&&!Number.isFinite(this.agent.maxSockets)){
+if(!this.agent.keepAlive&&!NumberIsFinite(this.agent.maxSockets)){
 this._last=true;
 this.shouldKeepAlive=false;
 }else{

lib/_stream_readable.js

@@ -23,6 +23,8 @@
 
 const{
  ArrayIsArray,
+ NumberIsInteger,
+ NumberIsNaN,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
 }=primordials;
@@ -389,7 +391,7 @@ function howMuchToRead(n, state){
 return0;
 if(state.objectMode)
 return1;
-if(Number.isNaN(n)){
+if(NumberIsNaN(n)){
 // Only flow one buffer at a time
 if(state.flowing&&state.length)
 returnstate.buffer.first().length;
@@ -408,7 +410,7 @@ Readable.prototype.read = function(n){
 // in this scenario, so we are doing it manually.
 if(n===undefined){
 n=NaN;
-}elseif(!Number.isInteger(n)){
+}elseif(!NumberIsInteger(n)){
 n=parseInt(n,10);
 }
 conststate=this._readableState;

lib/async_hooks.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const{
+ NumberIsSafeInteger,
  ReflectApply,
 }=primordials;
 
@@ -147,7 +148,7 @@ class AsyncResource{
 
 // Unlike emitInitScript, AsyncResource doesn't supports null as the
 // triggerAsyncId.
-if(!Number.isSafeInteger(triggerAsyncId)||triggerAsyncId<-1){
+if(!NumberIsSafeInteger(triggerAsyncId)||triggerAsyncId<-1){
 thrownewERR_INVALID_ASYNC_ID('triggerAsyncId',triggerAsyncId);
 }
 

lib/buffer.js

@@ -27,6 +27,9 @@ const{
  MathFloor,
  MathMin,
  MathTrunc,
+ NumberIsNaN,
+ NumberMAX_SAFE_INTEGER,
+ NumberMIN_SAFE_INTEGER,
  ObjectCreate,
  ObjectDefineProperties,
  ObjectDefineProperty,
@@ -175,9 +178,9 @@ function showFlaggedDeprecation(){
 
 functiontoInteger(n,defaultVal){
 n=+n;
-if(!Number.isNaN(n)&&
-n>=Number.MIN_SAFE_INTEGER&&
-n<=Number.MAX_SAFE_INTEGER){
+if(!NumberIsNaN(n)&&
+n>=NumberMIN_SAFE_INTEGER&&
+n<=NumberMAX_SAFE_INTEGER){
 return((n%1)===0 ? n : MathFloor(n));
 }
 returndefaultVal;
@@ -442,7 +445,7 @@ function fromArrayBuffer(obj, byteOffset, length){
 byteOffset=0;
 }else{
 byteOffset=+byteOffset;
-if(Number.isNaN(byteOffset))
+if(NumberIsNaN(byteOffset))
 byteOffset=0;
 }
 
@@ -890,7 +893,7 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir){
 // Coerce to Number. Values like null and [] become 0.
 byteOffset=+byteOffset;
 // If the offset is undefined, "foo",{}, coerces to NaN, search whole buffer.
-if(Number.isNaN(byteOffset)){
+if(NumberIsNaN(byteOffset)){
 byteOffset=dir ? 0 : buffer.length;
 }
 dir=!!dir;// Cast to bool.
@@ -1063,7 +1066,7 @@ function adjustOffset(offset, length){
 if(offset<length){
 returnoffset;
 }
-returnNumber.isNaN(offset) ? 0 : length;
+returnNumberIsNaN(offset) ? 0 : length;
 }
 
 Buffer.prototype.slice=functionslice(start,end){

lib/child_process.js

@@ -23,6 +23,7 @@
 
 const{
  ArrayIsArray,
+ NumberIsInteger,
  ObjectAssign,
  ObjectDefineProperty,
  ObjectPrototypeHasOwnProperty,
@@ -670,7 +671,7 @@ function execSync(command, options){
 
 
 functionvalidateTimeout(timeout){
-if(timeout!=null&&!(Number.isInteger(timeout)&&timeout>=0)){
+if(timeout!=null&&!(NumberIsInteger(timeout)&&timeout>=0)){
 thrownewERR_OUT_OF_RANGE('timeout','an unsigned integer',timeout);
 }
 }

lib/events.js

@@ -24,6 +24,7 @@
 const{
  Array,
  MathMin,
+ NumberIsNaN,
  ObjectCreate,
  ObjectDefineProperty,
  ObjectGetPrototypeOf,
@@ -79,7 +80,7 @@ ObjectDefineProperty(EventEmitter, 'defaultMaxListeners',{
 returndefaultMaxListeners;
 },
 set: function(arg){
-if(typeofarg!=='number'||arg<0||Number.isNaN(arg)){
+if(typeofarg!=='number'||arg<0||NumberIsNaN(arg)){
 thrownewERR_OUT_OF_RANGE('defaultMaxListeners',
 'a non-negative number',
 arg);
@@ -102,7 +103,7 @@ EventEmitter.init = function(){
 // Obviously not all Emitters should be limited to 10. This function allows
 // that to be increased. Set to zero for unlimited.
 EventEmitter.prototype.setMaxListeners=functionsetMaxListeners(n){
-if(typeofn!=='number'||n<0||Number.isNaN(n)){
+if(typeofn!=='number'||n<0||NumberIsNaN(n)){
 thrownewERR_OUT_OF_RANGE('n','a non-negative number',n);
 }
 this._maxListeners=n;

lib/fs.js

@@ -26,6 +26,7 @@
 
 const{
  MathMax,
+ NumberIsSafeInteger,
  ObjectCreate,
  ObjectDefineProperties,
  ObjectDefineProperty,
@@ -476,7 +477,7 @@ function read(fd, buffer, offset, length, position, callback){
 
 validateOffsetLengthRead(offset,length,buffer.byteLength);
 
-if(!Number.isSafeInteger(position))
+if(!NumberIsSafeInteger(position))
 position=-1;
 
 functionwrapper(err,bytesRead){
@@ -511,7 +512,7 @@ function readSync(fd, buffer, offset, length, position){
 
 validateOffsetLengthRead(offset,length,buffer.byteLength);
 
-if(!Number.isSafeInteger(position))
+if(!NumberIsSafeInteger(position))
 position=-1;
 
 constctx={};

lib/internal/async_hooks.js

@@ -2,6 +2,7 @@
 
 const{
  FunctionPrototypeBind,
+ NumberIsSafeInteger,
  ObjectDefineProperty,
 }=primordials;
 
@@ -118,7 +119,7 @@ function validateAsyncId(asyncId, type){
 // Skip validation when async_hooks is disabled
 if(async_hook_fields[kCheck]<=0)return;
 
-if(!Number.isSafeInteger(asyncId)||asyncId<-1){
+if(!NumberIsSafeInteger(asyncId)||asyncId<-1){
 fatalError(newERR_INVALID_ASYNC_ID(type,asyncId));
 }
 }
@@ -299,7 +300,7 @@ function clearDefaultTriggerAsyncId(){
 functiondefaultTriggerAsyncIdScope(triggerAsyncId,block, ...args){
 if(triggerAsyncId===undefined)
 returnblock(...args);
-// CHECK(Number.isSafeInteger(triggerAsyncId))
+// CHECK(NumberIsSafeInteger(triggerAsyncId))
 // CHECK(triggerAsyncId > 0)
 constoldDefaultTriggerAsyncId=async_id_fields[kDefaultTriggerAsyncId];
 async_id_fields[kDefaultTriggerAsyncId]=triggerAsyncId;

lib/internal/crypto/random.js

@@ -2,6 +2,7 @@
 
 const{
  MathMin,
+ NumberIsNaN,
 }=primordials;
 
 const{ AsyncWrap, Providers }=internalBinding('async_wrap');
@@ -23,7 +24,7 @@ function assertOffset(offset, elementSize, length){
 offset*=elementSize;
 
 constmaxLength=MathMin(length,kMaxPossibleLength);
-if(Number.isNaN(offset)||offset>maxLength||offset<0){
+if(NumberIsNaN(offset)||offset>maxLength||offset<0){
 thrownewERR_OUT_OF_RANGE('offset',`>= 0 && <= ${maxLength}`,offset);
 }
 
@@ -34,7 +35,7 @@ function assertSize(size, elementSize, offset, length){
 validateNumber(size,'size');
 size*=elementSize;
 
-if(Number.isNaN(size)||size>kMaxPossibleLength||size<0){
+if(NumberIsNaN(size)||size>kMaxPossibleLength||size<0){
 thrownewERR_OUT_OF_RANGE('size',
 `>= 0 && <= ${kMaxPossibleLength}`,size);
 }

lib/internal/errors.js

@@ -13,6 +13,7 @@
 const{
  ArrayIsArray,
  MathAbs,
+ NumberIsInteger,
  ObjectDefineProperty,
  ObjectKeys,
 }=primordials;
@@ -1113,7 +1114,7 @@ E('ERR_OUT_OF_RANGE',
 letmsg=replaceDefaultBoolean ? str :
 `The value of "${str}" is out of range.`;
 letreceived;
-if(Number.isInteger(input)&&MathAbs(input)>2**32){
+if(NumberIsInteger(input)&&MathAbs(input)>2**32){
 received=addNumericalSeparator(String(input));
 }elseif(typeofinput==='bigint'){
 received=String(input);