Revert "embedding: make Stop() stop Workers"

This reverts commit 037ac99. As flaky CI failures have revealed, this feature was implemented incorrectly. `stop_sub_worker_contexts()` needs to be called on the thread on which the `Environment` is currently running, it’s not thread-safe. The current API requires `Stop()` to be thread-safe, though. We could add a new API for this, but unless there’s demand, that’s probably not necessary as `FreeEnvironment()` will also stop Workers, which is commonly the next action on an `Environment` instance after having `Stop()` called on it. Refs: #32531 PR-URL: #32623 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Author: addaleax

src/api/environment.cc

@@ -712,7 +712,8 @@ ThreadId AllocateEnvironmentThreadId(){
 }
 
 voidDefaultProcessExitHandler(Environment* env, int exit_code){
-Stop(env);
+ env->set_can_call_into_js(false);
+ env->stop_sub_worker_contexts();
 DisposePlatform();
 uv_library_shutdown();
 exit(exit_code);

src/env.cc

@@ -550,10 +550,9 @@ void Environment::InitializeLibuv(bool start_profiler_idle_notifier){
  }
 }
 
-voidEnvironment::Stop(){
+voidEnvironment::ExitEnv(){
 set_can_call_into_js(false);
 set_stopping(true);
-stop_sub_worker_contexts();
  isolate_->TerminateExecution();
 SetImmediateThreadsafe([](Environment* env){uv_stop(env->event_loop())});
 }

src/env.h

@@ -926,7 +926,7 @@ class Environment : public MemoryRetainer{
 voidRegisterHandleCleanups();
 voidCleanupHandles();
 voidExit(int code);
-voidStop();
+voidExitEnv();
 
 // Register clean-up cb to be called on environment destruction.
 inlinevoidRegisterHandleCleanup(uv_handle_t* handle,

src/node.cc

@@ -1035,7 +1035,7 @@ int Start(int argc, char** argv){
 }
 
 intStop(Environment* env){
- env->Stop();
+ env->ExitEnv();
 return0;
 }
 

src/node.h

@@ -218,8 +218,7 @@ class Environment;
 NODE_EXTERN intStart(int argc, char* argv[]);
 
 // Tear down Node.js while it is running (there are active handles
-// in the loop and / or actively executing JavaScript code). This also stops
-// all Workers that may have been started earlier.
+// in the loop and / or actively executing JavaScript code).
 NODE_EXTERN intStop(Environment* env);
 
 // TODO(addaleax): Officially deprecate this and replace it with something
@@ -469,8 +468,8 @@ NODE_EXTERN void FreeEnvironment(Environment* env);
 // It receives the Environment* instance and the exit code as arguments.
 // This could e.g. call Stop(env); in order to terminate execution and stop
 // the event loop.
-// The default handler calls Stop(), disposes of the global V8 platform
-//instance, if one is being used, and calls exit().
+// The default handler disposes of the global V8 platform instance, if one is
+// being used, and calls exit().
 NODE_EXTERN voidSetProcessExitHandler(
  Environment* env,
  std::function<void(Environment*, int)>&& handler);