Skip to content

Commit 0a5ff4c

Browse files
refacktargos
authored andcommitted
deps: V8: template explicit instantiation for GCC-8
Fails to link for missing: void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...) Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent b411114 commit 0a5ff4c

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.9',
41+
'v8_embedder_string': '-node.10',
4242

4343
##### V8 defaults for Node.js #####
4444

‎deps/v8/src/elements.cc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@
6262
namespacev8{
6363
namespaceinternal{
6464

65+
// Explicit instantiation declarations.
66+
externtemplate voidJSObject::ApplyAttributesToDictionary(
67+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
68+
const PropertyAttributes attributes);
69+
6570

6671
namespace{
6772

‎deps/v8/src/objects/js-objects.cc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5836,5 +5836,10 @@ Handle<String> JSMessageObject::GetSourceLine() const{
58365836
return isolate->factory()->NewSubString(src, info.line_start, info.line_end);
58375837
}
58385838

5839+
// Explicit instantiation definitions.
5840+
template voidJSObject::ApplyAttributesToDictionary(
5841+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
5842+
const PropertyAttributes attributes);
5843+
58395844
} // namespace internal
58405845
} // namespace v8

0 commit comments

Comments
(0)