test: fix flaky test-fs-watch-encoding on OS X

PR-URL: #7356 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>

Author: Trott

test/parallel/test-fs-watch-encoding.js

@@ -1,54 +1,75 @@
 'use strict';
 
+// This test is a bit more complicated than it ideally needs to be to work
+// around issues on OS X and SmartOS.
+//
+// On OS X, watch events are subject to peculiar timing oddities such that an
+// event might fire out of order. The synchronous refreshing of the tmp
+// directory might trigger an event on the watchers that are instantiated after
+// it!
+//
+// On SmartOS, the watch events fire but the filename is null.
+
 constcommon=require('../common');
 constfs=require('fs');
 constpath=require('path');
-constassert=require('assert');
-
-if(common.isFreeBSD){
-common.skip('Test currently not working on FreeBSD');
-return;
-}
 
 common.refreshTmpDir();
 
 constfn='新建文夹件.txt';
 consta=path.join(common.tmpDir,fn);
 
+constwatchers=newSet();
+
+functionregisterWatcher(watcher){
+watchers.add(watcher);
+}
+
+functionunregisterWatcher(watcher){
+watcher.close();
+watchers.delete(watcher);
+if(watchers.size===0){
+clearInterval(interval);
+}
+}
+
 constwatcher1=fs.watch(
 common.tmpDir,
 {encoding: 'hex'},
 (event,filename)=>{
-if(filename)
-assert.equal(filename,'e696b0e5bbbae69687e5a4b9e4bbb62e747874');
-watcher1.close();
+if(['e696b0e5bbbae69687e5a4b9e4bbb62e747874',null].includes(filename))
+done(watcher1);
 }
 );
+registerWatcher(watcher1);
 
 constwatcher2=fs.watch(
 common.tmpDir,
 (event,filename)=>{
-if(filename)
-assert.equal(filename,fn);
-watcher2.close();
+if([fn,null].includes(filename))
+done(watcher2);
 }
 );
+registerWatcher(watcher2);
 
 constwatcher3=fs.watch(
 common.tmpDir,
 {encoding: 'buffer'},
 (event,filename)=>{
-if(filename){
-assert(filenameinstanceofBuffer);
-assert.equal(filename.toString('utf8'),fn);
-}
-watcher3.close();
+if(filenameinstanceofBuffer&&filename.toString('utf8')===fn)
+done(watcher3);
+elseif(filename===null)
+done(watcher3);
 }
 );
+registerWatcher(watcher3);
 
-constfd=fs.openSync(a,'w+');
-fs.closeSync(fd);
+constdone=common.mustCall(unregisterWatcher,watchers.size);
 
-process.on('exit',()=>{
-fs.unlink(a);
-});
+// OS X and perhaps other systems can have surprising race conditions with
+// file events. So repeat the operation in case it is missed the first time.
+constinterval=setInterval(()=>{
+constfd=fs.openSync(a,'w+');
+fs.closeSync(fd);
+fs.unlinkSync(a);
+},common.platformTimeout(100));