deps: update undici to 5.27.2

PR-URL: #50813 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: nodejs-github-bot

deps/undici/src/lib/client.js

@@ -1462,23 +1462,7 @@ function _resume (client, sync){
 return
 }
 
-if(util.isStream(request.body)&&util.bodyLength(request.body)===0){
-request.body
-.on('data',/* istanbul ignore next */function(){
-/* istanbul ignore next */
-assert(false)
-})
-.on('error',function(err){
-errorRequest(client,request,err)
-})
-.on('end',function(){
-util.destroy(this)
-})
-
-request.body=null
-}
-
-if(client[kRunning]>0&&
+if(client[kRunning]>0&&util.bodyLength(request.body)!==0&&
 (util.isStream(request.body)||util.isAsyncIterable(request.body))){
 // Request with stream or iterator body can error while other requests
 // are inflight and indirectly error those as well.
@@ -1499,6 +1483,11 @@ function _resume (client, sync){
 }
 }
 
+// https://www.rfc-editor.org/rfc/rfc7230#section-3.3.2
+functionshouldSendContentLength(method){
+returnmethod!=='GET'&&method!=='HEAD'&&method!=='OPTIONS'&&method!=='TRACE'&&method!=='CONNECT'
+}
+
 functionwrite(client,request){
 if(client[kHTTPConnVersion]==='h2'){
 writeH2(client,client[kHTTP2Session],request)
@@ -1527,7 +1516,9 @@ function write (client, request){
 body.read(0)
 }
 
-letcontentLength=util.bodyLength(body)
+constbodyLength=util.bodyLength(body)
+
+letcontentLength=bodyLength
 
 if(contentLength===null){
 contentLength=request.contentLength
@@ -1542,7 +1533,9 @@ function write (client, request){
 contentLength=null
 }
 
-if(request.contentLength!==null&&request.contentLength!==contentLength){
+// https://github.com/nodejs/undici/issues/2046
+// A user agent may send a Content-Length header with 0 value, this should be allowed.
+if(shouldSendContentLength(method)&&contentLength>0&&request.contentLength!==null&&request.contentLength!==contentLength){
 if(client[kStrictContentLength]){
 errorRequest(client,request,newRequestContentLengthMismatchError())
 returnfalse
@@ -1623,7 +1616,7 @@ function write (client, request){
 }
 
 /* istanbul ignore else: assertion */
-if(!body){
+if(!body||bodyLength===0){
 if(contentLength===0){
 socket.write(`${header}content-length: 0\r\n\r\n`,'latin1')
 }else{
@@ -1763,7 +1756,9 @@ function writeH2 (client, session, request){
 contentLength=null
 }
 
-if(request.contentLength!=null&&request.contentLength!==contentLength){
+// https://github.com/nodejs/undici/issues/2046
+// A user agent may send a Content-Length header with 0 value, this should be allowed.
+if(shouldSendContentLength(method)&&contentLength>0&&request.contentLength!=null&&request.contentLength!==contentLength){
 if(client[kStrictContentLength]){
 errorRequest(client,request,newRequestContentLengthMismatchError())
 returnfalse

deps/undici/src/lib/core/request.js

@@ -112,10 +112,29 @@ class Request{
 
 this.method=method
 
+this.abort=null
+
 if(body==null){
 this.body=null
 }elseif(util.isStream(body)){
 this.body=body
+
+constrState=this.body._readableState
+if(!rState||!rState.autoDestroy){
+this.endHandler=functionautoDestroy(){
+util.destroy(this)
+}
+this.body.on('end',this.endHandler)
+}
+
+this.errorHandler=err=>{
+if(this.abort){
+this.abort(err)
+}else{
+this.error=err
+}
+}
+this.body.on('error',this.errorHandler)
 }elseif(util.isBuffer(body)){
 this.body=body.byteLength ? body : null
 }elseif(ArrayBuffer.isView(body)){
@@ -236,7 +255,12 @@ class Request{
 assert(!this.aborted)
 assert(!this.completed)
 
-returnthis[kHandler].onConnect(abort)
+if(this.error){
+abort(this.error)
+}else{
+this.abort=abort
+returnthis[kHandler].onConnect(abort)
+}
 }
 
 onHeaders(statusCode,headers,resume,statusText){
@@ -265,6 +289,8 @@ class Request{
 }
 
 onComplete(trailers){
+this.onFinally()
+
 assert(!this.aborted)
 
 this.completed=true
@@ -275,6 +301,8 @@ class Request{
 }
 
 onError(error){
+this.onFinally()
+
 if(channels.error.hasSubscribers){
 channels.error.publish({request: this, error })
 }
@@ -286,6 +314,18 @@ class Request{
 returnthis[kHandler].onError(error)
 }
 
+onFinally(){
+if(this.errorHandler){
+this.body.off('error',this.errorHandler)
+this.errorHandler=null
+}
+
+if(this.endHandler){
+this.body.off('end',this.endHandler)
+this.endHandler=null
+}
+}
+
 // TODO: adjust to support H2
 addHeader(key,value){
 processHeader(this,key,value)

deps/undici/src/lib/core/util.js

@@ -190,7 +190,7 @@ function isReadableAborted (stream){
 }
 
 functiondestroy(stream,err){
-if(!isStream(stream)||isDestroyed(stream)){
+if(stream==null||!isStream(stream)||isDestroyed(stream)){
 return
 }
 

deps/undici/src/lib/pool.js

@@ -57,7 +57,7 @@ class Pool extends PoolBase{
  maxCachedSessions,
  allowH2,
  socketPath,
-timeout: connectTimeout==null ? 10e3 : connectTimeout,
+timeout: connectTimeout,
  ...(util.nodeHasAutoSelectFamily&&autoSelectFamily ? { autoSelectFamily, autoSelectFamilyAttemptTimeout } : undefined),
  ...connect
 })