esm: use "node:" namespace for builtins

Backport-PR-URL: #35757 PR-URL: #35387 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Author: guybedford

doc/api/esm.md

@@ -1007,7 +1007,7 @@ The resolver can throw the following errors:
 >1. If _selfUrl_ is not **undefined**, return _selfUrl_.
 >1. If _packageSubpath_ is _"."_ and _packageName_ is a Node.js builtin
 >module, then
->1. Return the string _"nodejs:"_ concatenated with _packageSpecifier_.
+>1. Return the string _"node:"_ concatenated with _packageSpecifier_.
 >1. While _parentURL_ is not the file system root,
 >1. Let _packageURL_ be the URL resolution of _"node_modules/"_
 > concatenated with _packageSpecifier_, relative to _parentURL_.

lib/internal/modules/esm/get_format.js

@@ -34,7 +34,7 @@ if (experimentalJsonModules)
 extensionFormatMap['.json']=legacyExtensionFormatMap['.json']='json';
 
 functiondefaultGetFormat(url,context,defaultGetFormatUnused){
-if(StringPrototypeStartsWith(url,'nodejs:')){
+if(StringPrototypeStartsWith(url,'node:')){
 return{format: 'builtin'};
 }
 constparsed=newURL(url);

lib/internal/modules/esm/resolve.js

@@ -750,13 +750,13 @@ function defaultResolve(specifier, context ={}, defaultResolveUnused){
 };
 }
 }catch{}
-if(parsed&&parsed.protocol==='nodejs:')
+if(parsed&&parsed.protocol==='node:')
 return{url: specifier};
 if(parsed&&parsed.protocol!=='file:'&&parsed.protocol!=='data:')
 thrownewERR_UNSUPPORTED_ESM_URL_SCHEME(parsed);
 if(NativeModule.canBeRequiredByUsers(specifier)){
 return{
-url: 'nodejs:'+specifier
+url: 'node:'+specifier
 };
 }
 if(parentURL&&StringPrototypeStartsWith(parentURL,'data:')){

lib/internal/modules/esm/translators.js

@@ -261,11 +261,11 @@ function cjsPreparseModuleExports(filename){
 // through normal resolution
 translators.set('builtin',asyncfunctionbuiltinStrategy(url){
 debug(`Translating BuiltinModule ${url}`);
-// Slice 'nodejs:' scheme
-constid=url.slice(7);
+// Slice 'node:' scheme
+constid=url.slice(5);
 constmodule=loadNativeModule(id,url,true);
-if(!url.startsWith('nodejs:')||!module){
-thrownewERR_UNKNOWN_BUILTIN_MODULE(id);
+if(!url.startsWith('node:')||!module){
+thrownewERR_UNKNOWN_BUILTIN_MODULE(url);
 }
 debug(`Loading BuiltinModule ${url}`);
 returnmodule.getESMFacade();

test/es-module/test-esm-dynamic-import.js

@@ -48,9 +48,9 @@ function expectFsNamespace(result){
 expectFsNamespace(import('fs'));
 expectFsNamespace(eval('import("fs")'));
 expectFsNamespace(eval('import("fs")'));
-expectFsNamespace(import('nodejs:fs'));
+expectFsNamespace(import('node:fs'));
 
-expectModuleError(import('nodejs:unknown'),
+expectModuleError(import('node:unknown'),
 'ERR_UNKNOWN_BUILTIN_MODULE');
 expectModuleError(import('./not-an-existing-module.mjs'),
 'ERR_MODULE_NOT_FOUND');

test/fixtures/es-module-loaders/example-loader.mjs

@@ -11,7 +11,7 @@ baseURL.pathname = process.cwd() + '/'
 exportfunctionresolve(specifier,{ parentURL =baseURL},defaultResolve){
 if(builtinModules.includes(specifier)){
 return{
-url: 'nodejs:'+specifier
+url: 'node:'+specifier
 };
 }
 if(/^\.{1,2}[/]/.test(specifier)!==true&&!specifier.startsWith('file:')){
@@ -27,7 +27,7 @@ export function resolve(specifier,{parentURL = baseURL }, defaultResolve){
 }
 
 exportfunctiongetFormat(url,context,defaultGetFormat){
-if(url.startsWith('nodejs:')&&builtinModules.includes(url.slice(7))){
+if(url.startsWith('node:')&&builtinModules.includes(url.slice(5))){
 return{
 format: 'builtin'
 };

test/fixtures/es-module-loaders/loader-unknown-builtin-module.mjs

@@ -1,14 +1,14 @@
 exportasyncfunctionresolve(specifier,{ parentURL },defaultResolve){
 if(specifier==='unknown-builtin-module'){
 return{
-url: 'nodejs:unknown-builtin-module'
+url: 'node:unknown-builtin-module'
 };
 }
 returndefaultResolve(specifier,{parentURL},defaultResolve);
 }
 
 exportasyncfunctiongetFormat(url,context,defaultGetFormat){
-if(url==='nodejs:unknown-builtin-module'){
+if(url==='node:unknown-builtin-module'){
 return{
 format: 'builtin'
 };

test/fixtures/es-module-loaders/not-found-assert-loader.mjs

@@ -14,7 +14,7 @@ export async function resolve(specifier,{parentURL }, defaultResolve){
 catch(e){
 assert.strictEqual(e.code,'ERR_MODULE_NOT_FOUND');
 return{
-url: 'nodejs:fs'
+url: 'node:fs'
 };
 }
 assert.fail(`Module resolution for ${specifier} should be throw ERR_MODULE_NOT_FOUND`);

test/parallel/test-loaders-unknown-builtin-module.mjs

@@ -2,7 +2,7 @@
 import{expectsError,mustCall}from'../common/index.mjs';
 importassertfrom'assert';
 
-constunknownBuiltinModule='unknown-builtin-module';
+constunknownBuiltinModule='node:unknown-builtin-module';
 
 import(unknownBuiltinModule)
 .then(assert.fail,expectsError({