Skip to content

Commit 12e9380

Browse files
vitosorrisoUlisesGascon
authored andcommitted
test: replace forEach with for-of in test-url-relative
PR-URL: #50788 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
1 parent be33b71 commit 12e9380

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

‎test/parallel/test-url-relative.js‎

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,15 @@ const relativeTests = [
5555
['http://localhost','file://foo/Users','file://foo/Users'],
5656
['https://registry.npmjs.org','@foo/bar','https://registry.npmjs.org/@foo/bar'],
5757
];
58-
relativeTests.forEach(function(relativeTest){
58+
for(leti=0;i<relativeTests.length;i++){
59+
constrelativeTest=relativeTests[i];
60+
5961
consta=url.resolve(relativeTest[0],relativeTest[1]);
6062
conste=relativeTest[2];
6163
assert.strictEqual(a,e,
6264
`resolve(${relativeTest[0]}, ${relativeTest[1]})`+
6365
` == ${e}\n actual=${a}`);
64-
});
66+
}
6567

6668
//
6769
// Tests below taken from Chiron
@@ -374,19 +376,23 @@ const relativeTests2 = [
374376
// No path at all
375377
['#hash1','#hash2','#hash1'],
376378
];
377-
relativeTests2.forEach(function(relativeTest){
379+
for(leti=0;i<relativeTests2.length;i++){
380+
constrelativeTest=relativeTests2[i];
381+
378382
consta=url.resolve(relativeTest[1],relativeTest[0]);
379383
conste=url.format(relativeTest[2]);
380384
assert.strictEqual(a,e,
381385
`resolve(${relativeTest[0]}, ${relativeTest[1]})`+
382386
` == ${e}\n actual=${a}`);
383-
});
387+
}
384388

385389
// If format and parse are inverse operations then
386390
// resolveObject(parse(x), y) == parse(resolve(x, y))
387391

388392
// format: [from, path, expected]
389-
relativeTests.forEach(function(relativeTest){
393+
for(leti=0;i<relativeTests.length;i++){
394+
constrelativeTest=relativeTests[i];
395+
390396
letactual=url.resolveObject(url.parse(relativeTest[0]),relativeTest[1]);
391397
letexpected=url.parse(relativeTest[2]);
392398

@@ -399,7 +405,8 @@ relativeTests.forEach(function(relativeTest){
399405
assert.strictEqual(actual,expected,
400406
`format(${actual}) == ${expected}\n`+
401407
`actual: ${actual}`);
402-
});
408+
409+
}
403410

404411
// format: [to, from, result]
405412
// the test: ['.//g', 'f:/a', 'f://g'] is a fundamental problem
@@ -415,7 +422,9 @@ if (relativeTests2[181][0] === './/g' &&
415422
relativeTests2[181][2]==='f://g'){
416423
relativeTests2.splice(181,1);
417424
}
418-
relativeTests2.forEach(function(relativeTest){
425+
for(leti=0;i<relativeTests2.length;i++){
426+
constrelativeTest=relativeTests2[i];
427+
419428
letactual=url.resolveObject(url.parse(relativeTest[1]),relativeTest[0]);
420429
letexpected=url.parse(relativeTest[2]);
421430

@@ -431,4 +440,4 @@ relativeTests2.forEach(function(relativeTest){
431440
assert.strictEqual(actual,expected,
432441
`format(${relativeTest[1]}) == ${expected}\n`+
433442
`actual: ${actual}`);
434-
});
443+
}

0 commit comments

Comments
(0)